Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix WPT runner result #44238

Merged

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Aug 14, 2022

This doesn't include the other tests in the result when running a specific test in WPT.

The following is a result tested with #44234.

To-Be

$ node test/wpt/test-streams.js readable-byte-streams/bad-buffers-and-views.any.js

[PASS] ReadableStream with byte source: reading into a zero-length view on a non-zero-length buffer rejects
{
  "readable-byte-streams/bad-buffers-and-views.any.js": {
    "fail": {
      "expected": [
        "ReadableStream with byte source: respondWithNewView() throws if the supplied view's buffer is zero-length (in the readable state)"
      ]
    }
  }
}
Ran 1/1 tests, 0 skipped, 0 passed, 1 expected failures, 0 unexpected failures, 0 unexpected passes

As-Is

$ node test/wpt/test-streams.js readable-byte-streams/bad-buffers-and-views.any.js

[PASS] ReadableStream with byte source: reading into a zero-length view on a non-zero-length buffer rejects
{
  "readable-byte-streams/bad-buffers-and-views.any.js": {
    "fail": {
      "expected": [
        "ReadableStream with byte source: respondWithNewView() throws if the supplied view's buffer is zero-length (in the readable state)"
      ]
    }
  }
}
Ran 64/64 tests, 0 skipped, 63 passed, 1 expected failures, 0 unexpected failures, 7 unexpected passes
/home/daeyeon/code/daeyeon.node/test/common/wpt.js:546
        throw new Error(
        ^

Error: Found 7 unexpected passes. Consider updating test/wpt/status/streams.json for these files:
piping/abort.any.js
queuing-strategies.any.js
readable-byte-streams/general.any.js
readable-byte-streams/tee.any.js
readable-streams/default-reader.any.js
readable-streams/templated.any.js
writable-streams/aborting.any.js
    at process.<anonymous> (/home/daeyeon/code/daeyeon.node/test/common/wpt.js:546:15)
    at process.emit (node:events:525:35)

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

This doesn't include the other tests for the result when
running a specific test in WPT.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 14, 2022
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Aug 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2022
@nodejs-github-bot
Copy link
Collaborator

@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2022
@nodejs-github-bot nodejs-github-bot merged commit a5d27f4 into nodejs:main Aug 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a5d27f4

@daeyeon daeyeon deleted the main.wpt-runner-220815.Mon.52ac branch August 26, 2022 09:02
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
This doesn't include the other tests for the result when
running a specific test in WPT.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
This doesn't include the other tests for the result when
running a specific test in WPT.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: nodejs#44238
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@juanarbol
Copy link
Member

Depends on #43455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants