Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.8.0 release proposal #44246

Closed
wants to merge 147 commits into from
Closed

v18.8.0 release proposal #44246

wants to merge 147 commits into from

Commits on Aug 8, 2022

  1. http: do not leak error listeners

    PR-URL: #43587
    Fixes: #43548
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    ShogunPanda authored and danielleadams committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    3af44c6 View commit details
    Browse the repository at this point in the history
  2. esm: move package config helpers

    PR-URL: #43967
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    GeoffreyBooth authored and danielleadams committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    c0d2098 View commit details
    Browse the repository at this point in the history
  3. tools: add verbose flag to find-inactive-collaborators

    PR-URL: #43964
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and danielleadams committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    091d015 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. doc: add missing test runner option

    PR-URL: #43989
    Refs: #43554
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    MoLow authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    51db352 View commit details
    Browse the repository at this point in the history
  2. test: change misleading variable name

    The return value of getPrime() is not a private key in any way.
    
    Refs: nodejs/node-v0.x-archive#2638
    
    PR-URL: #43990
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f6a7019 View commit details
    Browse the repository at this point in the history
  3. doc: fix typos in test.md

    PR-URL: #43997
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    aduh95 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    9856fc7 View commit details
    Browse the repository at this point in the history
  4. test: fix test-cluster-concurrent-disconnect

    The error code, `ECONNRESET`, is observed on linux.
    This commit adds it as an expected error code.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    
    PR-URL: #43961
    Refs: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/32901/testReport/junit/(root)/test/parallel_test_cluster_concurrent_disconnect/
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    daeyeon authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    62a0a4c View commit details
    Browse the repository at this point in the history
  5. test: reduce loop times for preventing test from timeout

    PR-URL: #43981
    Refs: nodejs/reliability#331
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    theanarkh authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c939e19 View commit details
    Browse the repository at this point in the history
  6. test_runner: validate concurrency option

    PR-URL: #43976
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aduh95 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ad1a823 View commit details
    Browse the repository at this point in the history
  7. net: add local family

    PR-URL: #43975
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    theanarkh authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3348dde View commit details
    Browse the repository at this point in the history
  8. test: remove test-gc-http-client-timeout from flaky list

    PR-URL: #43971
    Refs: #43949
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    F3n67u authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    373523b View commit details
    Browse the repository at this point in the history
  9. deps: cherry-pick 00704f5a from V8 upstream

    Original commit message:
    
        Add more efficient API for accesssing ArrayBuffer raw data
    
        Raw data access is already possible via GetBackingStore()->GetData().
        This API exposes a more efficient way for accessing
        JSArrayBuffer::backing_store (which, despite the confusing name, is no
        the BackingStore but its raw data pointer).
    
        Bug: v8:10343
        Change-Id: I695cea91e2c3de75ce6c86bac6e413ce6617958b
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764341
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#81745}
    
    Refs: v8/v8@00704f5
    Refs: #32226
    
    PR-URL: #43921
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c900bc1 View commit details
    Browse the repository at this point in the history
  10. lib: add Promise methods to avoid-prototype-pollution lint rule

    PR-URL: #43849
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    aduh95 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1a31e38 View commit details
    Browse the repository at this point in the history
  11. doc: fix typo in packages.md

    "previous" read like it should be "previously"
    
    PR-URL: #44005
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jtoar authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ad537e6 View commit details
    Browse the repository at this point in the history
  12. test_runner: graceful termination on --test only

    PR-URL: #43977
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e2a3bf3 View commit details
    Browse the repository at this point in the history
  13. http: reuse socket only when it is drained

    Ensuring every request is assigned to a drained socket or nothing.
    Because is has no benifit for a request to be attached to a non
    drained socket and it prevents the request from being assigned to
    a drained one, which might occur soon or already in the free pool
    We achieve this by claiming a socket as free only when the socket
    is drained.
    
    PR-URL: #43902
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    ywave620 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    cd8704d View commit details
    Browse the repository at this point in the history
  14. src: remove unnecessary cast in crypto_sig.cc

    ByteSource::Allocated accepts a void pointer now, so we do not need to
    cast the argument to a char pointer.
    
    Refs: #43202
    
    PR-URL: #44001
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    tniessen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    2c44730 View commit details
    Browse the repository at this point in the history
  15. doc: list supported MODP groups explicitly

    Instead of referring users to perl to find information about supported
    MODP groups in crypto_groups.h, explicitly list the groups with their
    respective strengths and with references to the defining RFC sections.
    
    Refs: #43896
    
    PR-URL: #43986
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bf9bcef View commit details
    Browse the repository at this point in the history
  16. src,lib: print source map error source on demand

    The source context is not prepended to the value of the `stack` property
    when the source map is not enabled. Rather than prepending the error
    source context to the value of the `stack` property unconditionally,
    this patch aligns the behavior and only prints the source context when
    the error is not handled by userland (e.g. fatal errors).
    
    Also, this patch fixes that when source-map support is enabled, the
    error source context is not pointing to where the error was thrown.
    
    PR-URL: #43875
    Fixes: #43186
    Fixes: #41541
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    legendecas authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f7a6235 View commit details
    Browse the repository at this point in the history
  17. lib: add missing env vars to --help

    PR-URL: #43492
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    cola119 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a0a7bc1 View commit details
    Browse the repository at this point in the history
  18. doc: add missing env vars to man page

    PR-URL: #43492
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    cola119 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3853665 View commit details
    Browse the repository at this point in the history
  19. doc: remove old reference from crypto/README.md

    The referenced header file does not exist anymore.
    
    Refs: #43896
    
    PR-URL: #44012
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    tniessen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    d1e6989 View commit details
    Browse the repository at this point in the history
  20. src: fix typo in src/README.md

    PR-URL: #44009
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    addaleax authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ca24eac View commit details
    Browse the repository at this point in the history
  21. test_runner: fix top level describe queuing

    PR-URL: #43998
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    24baa87 View commit details
    Browse the repository at this point in the history
  22. deps: upgrade npm to 8.15.1

    PR-URL: #44013
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    npm-cli-bot authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6bf688d View commit details
    Browse the repository at this point in the history
  23. src: improve SPKAC::ExportChallenge()

    Declare buf as an unsigned char to get rid of the reinterpret_cast and
    do not ignore the return value of ASN1_STRING_TO_UTF8. This also removes
    the need to call strlen() on the result.
    
    PR-URL: #44002
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1196023 View commit details
    Browse the repository at this point in the history
  24. src: fix to use replacement character

    PR-URL: #43999
    Fixes: #43962
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    cola119 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b4677f7 View commit details
    Browse the repository at this point in the history
  25. test: refactor ESM tests to improve performance

    PR-URL: #43784
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    JakobJingleheimer authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    cbc1189 View commit details
    Browse the repository at this point in the history
  26. http: make idle http parser count configurable

    PR-URL: #43974
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    theanarkh authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0b909a4 View commit details
    Browse the repository at this point in the history
  27. src,fs: refactor duplicated code in fs.readdir

    `AfterScanDirWithTypes` is almost same as `AfterScanDir` except for
    handling the `with file types` option. This merges the two functions
    into one.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    
    PR-URL: #43204
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    daeyeon authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    40ef04c View commit details
    Browse the repository at this point in the history
  28. meta: shorten PowerShell snippet for bug-report template

    PR-URL: #44011
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    NicoNekoru authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c4e8f95 View commit details
    Browse the repository at this point in the history
  29. src: fix bug in GetErrorSource()

    Refs: #43875
    
    PR-URL: #44019
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    tniessen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6343e1d View commit details
    Browse the repository at this point in the history
  30. doc: claim ABI version for Electron 21

    PR-URL: #44034
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    VerteDinde authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    9fd4262 View commit details
    Browse the repository at this point in the history
  31. doc: fix code examples in crypto.md

    PR-URL: #44053
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    aduh95 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    dd34dd9 View commit details
    Browse the repository at this point in the history
  32. test_runner: add before/after/each hooks

    PR-URL: #43730
    Fixes: #43403
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    d8a03cc View commit details
    Browse the repository at this point in the history
  33. src: use a typed array internally for process._exiting

    This would prevent manual writes to the _exiting JS property on the
    process object by passing the data directly via a typed array for
    performance.
    
    This change partially addresses this TODO:
    https://github.com/nodejs/node/blob/3d575a4f1bd197c3ce669758a2a3c763462a883a/src/api/hooks.cc#L68-L71
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #43883
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    RaisinTen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b935c4f View commit details
    Browse the repository at this point in the history
  34. doc: clarify part of onboarding guide regarding adding to teams

    There are a number of teams (for example, the build team) which require
    more than just showing interest as a prerequisite for being added, so
    this change adds a link to the set of subsystem teams where new
    Collaborators can be added directy.
    
    Also, the doc didn't actually mention if the new Collaborator should be
    added to the team. This change also clarifies that.
    
    Refs: nodejs/build#3003
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #44024
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RaisinTen authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c7fdc53 View commit details
    Browse the repository at this point in the history
  35. tools: update lint-md-dependencies to rollup@2.77.2

    PR-URL: #44064
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    nodejs-github-bot authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    65887b6 View commit details
    Browse the repository at this point in the history
  36. test: remove duplicate test

    `test/parallel/test-http-agent-no-wait.js` is basically a duplicate of
    `test/parallel/test-http-client-close-with-default-agent.js`, remove it.
    
    PR-URL: #44051
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    lpinca authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f882318 View commit details
    Browse the repository at this point in the history
  37. test: fix internet/test-inspector-help-page

    This gets the test to use its own `https.agent` instead of the default
    one.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    
    PR-URL: #44025
    Refs: #43522
    Refs: https://github.com/nodejs/node/actions/workflows/test-internet.yml
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    daeyeon authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f27e003 View commit details
    Browse the repository at this point in the history
  38. doc: add kvakil to triagers

    I am volunteering to be a triager. I'd like to become more involved,
    help users with their issues, and eventually become a collaborator.
    
    I've understood & agree to the code of conduct.
    
    PR-URL: #43996
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a6c6e88 View commit details
    Browse the repository at this point in the history
  39. test_runner: empty pending tests queue post running

    PR-URL: #44059
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    45f580f View commit details
    Browse the repository at this point in the history
  40. doc: copyedit test.md

    PR-URL: #44061
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aduh95 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    cd64813 View commit details
    Browse the repository at this point in the history
  41. build: skip test-internet run on forks

    Do not run test-internet scheduled GitHub Action on forks.
    
    PR-URL: #44054
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    273c532 View commit details
    Browse the repository at this point in the history
  42. net,tls: pass a valid socket on tlsClientError

    On the 'tlsClientError' event, the `tlsSocket` instance is passed as
    `closed` status. Thus, users can't get information such as `remote
    address`, `remoteFamily`, and so on.
    
    This adds a flag to close a socket after emitting an `error` event.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44021
    Fixes: #43963
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    daeyeon authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6a4e99b View commit details
    Browse the repository at this point in the history
  43. doc: update collaborator email

    Updating my email on the collaborator section of README.
    
    PR-URL: #44044
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    ruyadorno authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    df91dc1 View commit details
    Browse the repository at this point in the history
  44. doc: add ErickWendel to collaborators

    Fixes: #43755
    PR-URL: #44088
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    ErickWendel authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1a9ae91 View commit details
    Browse the repository at this point in the history
  45. meta: update AUTHORS

    PR-URL: #44065
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    62fd899 View commit details
    Browse the repository at this point in the history
  46. test_runner: verbous error when entire test tree is canceled

    PR-URL: #44060
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b45ad00 View commit details
    Browse the repository at this point in the history
  47. build: allow test-internet on forks if not scheduled

    Refs: #44054 (comment)
    PR-URL: #44073
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Trott authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    befe01c View commit details
    Browse the repository at this point in the history
  48. net: create diagnostics channels lazily

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5cb5c65 View commit details
    Browse the repository at this point in the history
  49. bootstrap: implement --snapshot-blob and --build-snapshot

    This patch introduces `--build-snapshot` and `--snapshot-blob` options
    for creating and using user land snapshots.
    
    For the initial iteration, user land CJS modules and ESM are not yet
    supported in the snapshot, so only one single file can be snapshotted
    (users can bundle their applications into a single script with their
    bundler of choice to build a snapshot though).
    
    A subset of builtins should already work, and support for more builtins
    are being added. This PR includes tests checking that the TypeScript
    compiler and the marked markdown renderer (and the builtins they use)
    can be snapshotted and deserialized.
    
    To generate a snapshot using `snapshot.js` as entry point and write the
    snapshot blob to `snapshot.blob`:
    
    ```
    $ echo "globalThis.foo = 'I am from the snapshot'" > snapshot.js
    $ node --snapshot-blob snapshot.blob --build-snapshot snapshot.js
    ```
    
    To restore application state from `snapshot.blob`, with `index.js` as
    the entry point script for the deserialized application:
    
    ```
    $ echo "console.log(globalThis.foo)" > index.js
    $ node --snapshot-blob snapshot.blob index.js
    I am from the snapshot
    ```
    
    Users can also use the `v8.startupSnapshot` API to specify an entry
    point at snapshot building time, thus avoiding the need of an additional
    entry script at deserialization time:
    
    ```
    $ echo "require('v8').startupSnapshot.setDeserializeMainFunction(() => console.log('I am from the snapshot'))" > snapshot.js
    $ node --snapshot-blob snapshot.blob --build-snapshot snapshot.js
    $ node --snapshot-blob snapshot.blob
    I am from the snapshot
    ```
    
    Note that this patch only adds functionality to the `node` executable
    for building run-time user-land snapshots, the generated snapshot is
    stored into a separate file on disk. Building a single binary with both
    Node.js and an embedded snapshot has already been possible with the
    `--node-snapshot-main` option to the `configure` script if the user
    compiles Node.js from source. It would be a different task to enable the
    `node` executable to produce a single binary that contains both Node.js
    and an embedded snapshot without building Node.js from source, which
    should be layered on top of the SEA (Single Executable Apps) initiative.
    
    Known limitations/bugs that are being fixed in the upstream:
    
    - V8 hits a DCHECK when deserializing certain mutated globals, e.g.
      `Error.stackTraceLimit` (it should work fine in the release build,
      however): https://chromium-review.googlesource.com/c/v8/v8/+/3319481
    - Layout of V8's read-only heap can be inconsistent after
      deserialization, resulting in memory corruption:
      https://bugs.chromium.org/p/v8/issues/detail?id=12921
    
    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    31589b5 View commit details
    Browse the repository at this point in the history
  50. bootstrap: clean up warning setup during serialization

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    54c8339 View commit details
    Browse the repository at this point in the history
  51. test: add UMD module test with marked

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c5e04c5 View commit details
    Browse the repository at this point in the history
  52. test: test snapshotting TypeScript compiler

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    02e10a5 View commit details
    Browse the repository at this point in the history
  53. src: nest namespace report in namespace node

    PR-URL: #44069
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    legendecas authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    975931d View commit details
    Browse the repository at this point in the history
  54. src: remove usages of GetBackingStore in startup

    This removes all usages of GetBackingStore in startup. See the linked
    issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44078
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    43e8be0 View commit details
    Browse the repository at this point in the history
  55. src: remove usages of GetBackingStore in WASI

    This removes all usages of GetBackingStore in WASI. See the linked issue
    for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44077
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ddf9c16 View commit details
    Browse the repository at this point in the history
  56. src: remove usages of GetBackingStore in modules

    This removes all usages of GetBackingStore in modules. See the linked
    issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44076
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    34a92d1 View commit details
    Browse the repository at this point in the history
  57. src: remove usages of GetBackingStore in node-api

    This removes all usages of GetBackingStore in `node-api`. See the linked
    issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44075
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    8a79636 View commit details
    Browse the repository at this point in the history
  58. src: remove unowned usages of GetBackingStore

    This removes all usages of GetBackingStore without any entries in the
    `CODEOWNERS` file. For the most part this is a pretty straightforward
    review; except `SPREAD_BUFFER_ARG` and the changes to `CopyArrayBuffer`.
    
    See the linked issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44080
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c7373b7 View commit details
    Browse the repository at this point in the history
  59. meta: add codeowner for src/node_snapshot*

    PR-URL: #44113
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    legendecas authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0de278c View commit details
    Browse the repository at this point in the history
  60. src,test: fix typos

    * src: fix typo in `src/node_messaging.h` (`postMesssage` ->
      `postMessage`).
    * test/es-module: fix typo in `test-cjs-exports.js` (`eror` -> `error`).
    
    PR-URL: #44110
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    sadikkuzu authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0e67128 View commit details
    Browse the repository at this point in the history
  61. doc: update repository list in onboarding doc

    LTS repo is now Release.
    
    readable-stream is important but a bit of a specialized topic. The
    others listed here are of general interest.
    
    PR-URL: #44089
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5adf039 View commit details
    Browse the repository at this point in the history
  62. doc: clarify tls.tlsSocket.getCipher().version

    The getCipher() returns a tuple that includes protocol version string.
    This string refers to the minimum protocol version string, as per
    documentation. What is missing is a reference to the documentation
    where to get the negotiated cipher for the socket connection and
    a clearer example.
    
    Fixes: #43406
    PR-URL: #44086
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    AdamMajer authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    29bbabd View commit details
    Browse the repository at this point in the history
  63. net, dns: socket should handle its output as input

    As a consequence of #43014 ,
    server sockets and others, once connected, report string family
    names. But when feeding these to Socket.connect(), it passes
    these to host resolution with a string for family while a numeric
    family is expected internally. This results in wrong hints flags
    to be set and resolution to fail.
    
    As solution, is to add ability to handle both numeric and string
    family names when doing lookup and connect.
    
    Fixes: #44003
    PR-URL: #44083
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    AdamMajer authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e6a47e8 View commit details
    Browse the repository at this point in the history
  64. src,buffer: remove unused chars_written parameter

    This parameter was always being set to `nullptr` by its callers, either
    explicitly or implicitly via the default argument. It was also buggy, as
    in some cases it wouldn't be written to, potentially leaking stack
    memory (see the early returns in `StringBytes::WriteUCS2`). Remove it
    entirely.
    
    PR-URL: #44092
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    08f6f1c View commit details
    Browse the repository at this point in the history
  65. test_runner: refactor to use more primordials

    PR-URL: #44062
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    aduh95 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a36befa View commit details
    Browse the repository at this point in the history
  66. doc,worker: deprecate --trace-atomics-wait

    V8 has asked if it possible to remove the functionality underlying
    `--trace-atomics-wait`. Let's start with a documentation-only
    deprecation.
    
    PR-URL: #44093
    Refs: #42982
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    68c4e45 View commit details
    Browse the repository at this point in the history
  67. doc: add theanarkh to collaborators

    Fixes: #44006
    PR-URL: #44131
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    theanarkh authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    1f33319 View commit details
    Browse the repository at this point in the history
  68. deps: upgrade base64 to dc6a41ce36e

    Fixes: #43894
    PR-URL: #44032
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    mscdex authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6cfb1ac View commit details
    Browse the repository at this point in the history
  69. bootstrap: support more builtins in the embedded code cache

    This patch:
    
    - Make NativeModuleLoader::LookupAndCompile() detect parameters based
      on module IDs. This allows us to compile more builtins when
      generating the embedded bootstrap, including
      - internal/per_context/*
      - internal/bootstrap/*
      - internal/main/*
    - Move pre_execution.js to lib/internal/process as it needs to be
      compiled as a regular built-in module, unlike other scripts
      in lib/internal/bootstrap
    - Move markBootstrapComplete() to the performance binding instead of
      making it a function-wrapper-based global to reduce number of
      special cases.
    
    PR-URL: #44018
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    2178f17 View commit details
    Browse the repository at this point in the history
  70. esm: fix loader hooks accepting too many arguments

    PR-URL: #44109
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    JakobJingleheimer authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c2ea22f View commit details
    Browse the repository at this point in the history
  71. doc: remove unused code in call tracker example

    This function appears to be unused, so remove it.
    
    PR-URL: #44127
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    cjihrig authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f461d79 View commit details
    Browse the repository at this point in the history
  72. bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder

    To improve startup performance.
    
    PR-URL: #44104
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bd27b8b View commit details
    Browse the repository at this point in the history
  73. stream: update TextEncoderStream to align the latest spec

    PR-URL: #44101
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    cola119 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    e057480 View commit details
    Browse the repository at this point in the history
  74. src: remove usages of GetBackingStore in crypto

    This removes all usages of GetBackingStore in `crypto`. See the
    linked issue for an explanation.
    
    Note: I am not sure of the lifetime semantics intended by
    `ArrayBufferOrViewContents` -- I am pretty sure it is correct based on
    a manual audit of the callsites, but please ensure that it is correct.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44079
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ebff06b View commit details
    Browse the repository at this point in the history
  75. module: protect against prototype mutation

    Ensures that mutating the `Object` prototype does not influence the
    parsing of `package.json` files.
    
    PR-URL: #44007
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    aduh95 authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3f32526 View commit details
    Browse the repository at this point in the history
  76. lib: pass env variables to child process on z/OS

    PR-URL: #42255
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    alexcfyung authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3dbbaa0 View commit details
    Browse the repository at this point in the history
  77. deps: upgrade npm to 8.16.0

    PR-URL: #44119
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    npm-cli-bot authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    d6ebc75 View commit details
    Browse the repository at this point in the history
  78. deps: remove unnecessary file

    PR-URL: #44133
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    mscdex authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    646417c View commit details
    Browse the repository at this point in the history
  79. test: tune down parallelism for some flaky tests

    These tests seem to timeout quite often. I don't know why, but one
    possible reason is that they are starting a lot of threads. It seems
    that tests in `test/parallel` are assumed to only start one thread each,
    so having 11 threads running at a time feels like a lot.
    
    It also seems that these tests fail in a correlated fashion: take a look
    at [this reliability report][]. The failures all occur on the same build
    machines on the same PRs. This suggests to me some sort of CPU
    contention.
    
    [this reliability report]: nodejs/reliability#334
    
    On my Linux machine decreasing the parallelism & iterations here reduce
    the `user` time from ~11.5 seconds to ~2 seconds, depending on the test.
    I have seen these tests take 30-60 seconds on CI (Alpine in particular).
    
    I went back to the diffs that introduced that introduced these changes
    and verified that they failed at least 90% of the time with the reduced
    iteration count, which feels sufficient.
    
    Refs: #43499
    Refs: #43084
    PR-URL: #44090
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    kvakil authored and danielleadams committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    9fc9534 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. http: trace http request / response

    PR-URL: #44102
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    theanarkh authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ed36b0d View commit details
    Browse the repository at this point in the history
  2. src: add detailed embedder process initialization API

    So far, process initialization has been a bit all over the place
    in Node.js. `InitializeNodeWithArgs()` is our main public API
    for this, but inclusion of items in it vs. `InitializeOncePerProcess()`
    and `PlatformInit()` has been random at best. Likewise,
    some pieces of initialization have been guarded by
    `NODE_SHARED_MODE`, but also fairly randomly and without
    any meaningful connection to shared library usage.
    
    This leaves embedders in a position to cherry-pick some of
    the initialization code into their own code to make their
    application behave like typical Node.js applications to the
    degree to which they desire it.
    
    Electron takes an alternative route and makes direct use of
    `InitializeOncePerProcess()` already while it is a private
    API, with a `TODO` to add it to the public API in Node.js.
    
    This commit addresses that `TODO`, and `TODO`s around the
    `NODE_SHARED_MODE` usage. Specifically:
    
    - `InitializeOncePerProcess()` and `TearDownOncePerProcess()`
      are added to the public API.
    - The `flags` option of these functions are merged with the
      `flags` option for `InitializeNodeWithArgs()`, since they
      essentially share the same semantics.
    - The return value of the function is made an abstract class,
      rather than a struct, for easier API/ABI stability.
    - Initialization code from `main()` is brought into these
      functions (since that makes sense in general).
    - Add a `TODO` for turning `InitializeNodeWithArgs()` into
      a small wrapper around `InitializeOncePerProcess()` and
      eventually removing it (at least one major release cycle
      each, presumably).
    - Remove `NODE_SHARED_MODE` guards and replace them with
      runtime options.
    
    PR-URL: #44121
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    addaleax authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    9dc33f1 View commit details
    Browse the repository at this point in the history
  3. deps: V8: cherry-pick 9861ce1deae2

    Original commit message:
    
        PPC: pass a scratch reg when using register_location
    
        Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
        Reviewed-by: Junliang Yan <junyan@redhat.com>
        Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
        Cr-Commit-Position: refs/heads/main@{#82146}
    
    Fixes: #44055
    PR-URL: #44115
    Refs: v8/v8@9861ce1
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    miladfarca authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    6256bd5 View commit details
    Browse the repository at this point in the history
  4. src: prevent copying ArrayBufferViewContents

    It is error-prone to copy or heap-allocate `ArrayBufferViewContents`,
    because you might accidentally cause it to exceed the lifetime of its
    argument. Let's make it impossible to do so. Fortunately we were not
    doing so anywhere already, so this diff is purely defensive.
    
    Refs: #44079 (comment)
    PR-URL: #44091
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    kvakil authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    8082c24 View commit details
    Browse the repository at this point in the history
  5. tools: update undici CPE in vuln checking script

    This changes the search method for `undici` on the NVD database.
    Before, since `undici` did not have a CPE assigned, the search
    was by keyword. Now that a CPE was assigned, it is used to query
    for new vulnerabilities.
    
    PR-URL: #44128
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    facutuesca authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    6c4b2e0 View commit details
    Browse the repository at this point in the history
  6. src,lib: print prinstine source when source map source not found

    Print unmapped source lines when the source map source is not
    found. Error stacks should be correctly mapped even when the
    source is absent.
    
    PR-URL: #44052
    Refs: #44019
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    legendecas authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    63b5c49 View commit details
    Browse the repository at this point in the history
  7. doc: add performance note to --enable-source-maps docs

    PR-URL: #43817
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    saurabhdaware authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    51b4a1b View commit details
    Browse the repository at this point in the history
  8. test: s390x z15 accelerated zlib fixes

    Modern s390x x15 has accelerated zlib operations on the CPU. Many
    distros currently have patches to take advantage of this feature. One
    side-effect of these patches is that compression routine is no longer
    deterministic as with software. Interruption to input produces
    different compressed results. Invalid input can result in processor
    fault.
    
    PR-URL: #44117
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    AdamMajer authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    1598894 View commit details
    Browse the repository at this point in the history
  9. doc: add Retry CI in collaborator guide

    PR-URL: #44130
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    LiviaMedeiros authored and danielleadams committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    eded43c View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. build: optimized and fixed building configuration to Android

    PR-URL: #44016
    Reviewed-By: Yash Ladha <yash@yashladha.in>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    MeowShe authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    2b89d11 View commit details
    Browse the repository at this point in the history
  2. test: remove test-http-client-response-timeout flaky designation

    The issue was fixed by #43890.
    
    Fixes: #43680
    PR-URL: #44145
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    lpinca authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c75c478 View commit details
    Browse the repository at this point in the history
  3. test: move test-vm-break-on-sigint to sequential

    This PR moves `test-vm-break-on-sigint.js` to sequential, following the
    other PRs I have made to move CPU intensive tests into sequential. The
    test has already been tuned to do less iterations in a previous PR.
    However it is still causing ~7% of build failures. The timeouts seem
    highly correlated with other tests which spawn a bunch of threads also
    failing, see for example the [first Jenkins failure][] and the [last
    Jenkins failure][].
    
    [first Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45756/
    [last Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45837/
    
    Refs: #44090
    Refs: #43981
    Refs: nodejs/reliability#337
    PR-URL: #44140
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    kvakil authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    41ecf71 View commit details
    Browse the repository at this point in the history
  4. test: deflake gc-http-client tests by restricting number of requests

    sequential/test-gc-http-client tests were sometimes failing due to
    a non-deterministic number of requests being created, causing the
    test to fail on some systems with a "ECONNRESET" error caused by
    too many concurrent connections
    
    Fixes: #43638
    PR-URL: #44146
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nicksia-vgw authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    7007a9f View commit details
    Browse the repository at this point in the history
  5. test: move tests with many workers to sequential

    These tests spawn many workers, which may be CPU intensive causing
    timeouts (see the referenced PR for more details). Let's move them
    to sequential.
    
    Refs: #44090
    PR-URL: #44139
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    kvakil authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    fcd5f7a View commit details
    Browse the repository at this point in the history
  6. meta: update AUTHORS

    PR-URL: #44161
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    601b03d View commit details
    Browse the repository at this point in the history
  7. tools: update lint-md-dependencies to @rollup/plugin-commonjs@22.0.2

    PR-URL: #44160
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    2a38896 View commit details
    Browse the repository at this point in the history
  8. deps: update corepack to 0.12.2

    PR-URL: #44159
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    7d89e1b View commit details
    Browse the repository at this point in the history
  9. build: add workflow to label flaky-test platform

    This workflow adds platform labels on `flaky-test` issues to make it
    easier and more reliable for someone to use labels to (for example)
    find all flaky tests on SmartOS or all flaky tests on FreeBSD.
    
    PR-URL: #44042
    Fixes: #43854
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RafaelGSS authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    5e1ab72 View commit details
    Browse the repository at this point in the history
  10. tools: update eslint to 8.21.0

    PR-URL: #44162
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3adecad View commit details
    Browse the repository at this point in the history
  11. deps: update undici to 5.8.1

    PR-URL: #44158
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    14b34e5 View commit details
    Browse the repository at this point in the history
  12. esm: do not bind loader hook functions

    PR-URL: #44122
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aduh95 authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c975427 View commit details
    Browse the repository at this point in the history
  13. test: update console web platform tests

    PR-URL: #44100
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    bcb94aa View commit details
    Browse the repository at this point in the history
  14. test: update hr-time web platform tests

    PR-URL: #44100
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ba1915d View commit details
    Browse the repository at this point in the history
  15. test: update wasm/jsapi web platform tests

    PR-URL: #44100
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    fad0630 View commit details
    Browse the repository at this point in the history
  16. lib: fix diagnostics channel

    PR-URL: #44154
    Fixes: #44143
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    theanarkh authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    1c51d83 View commit details
    Browse the repository at this point in the history
  17. src: disambiguate terms used to refer to builtins and addons

    The term "native module" dates back to some of the oldest code
    in the code base. Within the context of Node.js core it usually
    refers to modules that are native to Node.js (e.g. fs, http),
    but it can cause confusion for people who don't work on this
    part of the code base, as "native module" can also refer to
    native addons - which is even the case in some of the API
    docs and error messages.
    
    This patch tries to make the usage of these terms more consistent.
    Now within the context of Node.js core:
    
    - JavaScript scripts that are built-in to Node.js are now referred
      to as "built-in(s)". If they are available as modules,
      they can also be referred to as "built-in module(s)".
    - Dynamically-linked shared objects that are loaded into
      the Node.js processes are referred to as "addons".
    
    We will try to avoid using the term "native modules" because it could
    be ambiguous.
    
    Changes in this patch:
    
    File names:
    - node_native_module.h -> node_builtins.h,
    - node_native_module.cc -> node_builtins.cc
    
    C++ binding names:
    - `native_module` -> `builtins`
    
    `node::Environment`:
    - `native_modules_without_cache` -> `builtins_without_cache`
    - `native_modules_with_cache` -> `builtins_with_cache`
    - `native_modules_in_snapshot` -> `builtins_in_cache`
    - `native_module_require` -> `builtin_module_require`
    
    `node::EnvSerializeInfo`:
    - `native_modules` -> `builtins
    
    `node::native_module::NativeModuleLoader`:
    - `native_module` namespace -> `builtins` namespace
    - `NativeModuleLoader` -> `BuiltinLoader`
    - `NativeModuleRecordMap` -> `BuiltinSourceMap`
    - `NativeModuleCacheMap` -> `BuiltinCodeCacheMap`
    - `ModuleIds` -> `BuiltinIds`
    - `ModuleCategories` -> `BuiltinCategories`
    - `LoadBuiltinModuleSource` -> `LoadBuiltinSource`
    
    `loader.js`:
    - `NativeModule` -> `BuiltinModule` (the `NativeModule` name used in
      `process.moduleLoadList` is kept for compatibility)
    
    And other clarifications in the documentation and comments.
    
    PR-URL: #44135
    Fixes: #44036
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    joyeecheung authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    70bb6a3 View commit details
    Browse the repository at this point in the history
  18. src: fix cppgc incompatibility in v8

    This patch updates the layout of the BaseObjects to make sure
    that the first embedder field of them is a "type" pointer, the
    first 16 bits of which are the Node.js embedder ID, so that
    cppgc will always skip over them. In addition we now use this
    field to determine if the native object should be interpreted
    as a Node.js embedder object in the serialization and deserialization
    callbacks for the startup snapshot to improve the reliability.
    
    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    PR-URL: #43521
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    2 people authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c51d85e View commit details
    Browse the repository at this point in the history
  19. http: fix error message when specifying headerTimeout for createServer

    This change fixes the message on the error received when calling
    http.createServer(...) with a header timeout greater than the request
    timeout is incorrect.
    
    The validation requires that the header timeout is lower than the
    request timeout, but the error message asks for the opposite.
    
    PR-URL: #44163
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    nicksia-vgw authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    f5fcd49 View commit details
    Browse the repository at this point in the history
  20. bootstrap: check more metadata when loading the snapshot

    This patch stores the metadata about the Node.js binary
    into the SnapshotData and adds fields denoting how the
    snapshot was generated, on what platform it was
    generated as well as the V8 cached data version flag.
    Instead of simply crashing when the metadata doesn't
    match, Node.js now prints an error message and exit with
    1 for the customized snapshot, or ignore the snapshot
    and start from scratch if it's the default one.
    
    PR-URL: #44132
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    98fa488 View commit details
    Browse the repository at this point in the history
  21. deps: update undici to 5.8.2

    PR-URL: #44187
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    273014b View commit details
    Browse the repository at this point in the history
  22. test: update wpt url status

    PR-URL: #44175
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cola119 authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    7104210 View commit details
    Browse the repository at this point in the history
  23. events: use bitset to save memory

    PR-URL: #43700
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mabaasit authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    eac875e View commit details
    Browse the repository at this point in the history
  24. test: update WPT runner

    PR-URL: #43455
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c5c3c5e View commit details
    Browse the repository at this point in the history
  25. doc: fix typo in diagnostics_channel

    The diagnostics_channel Channel class description had
    a typo.
    
    PR-URL: #44199
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    evanlucas authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    03321cb View commit details
    Browse the repository at this point in the history
  26. perf_hooks: fix gc elapsed time

    PR-URL: #44058
    Refs: #44046
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    theanarkh authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9fedf35 View commit details
    Browse the repository at this point in the history
  27. doc: update tags in adding-new-napi-api.md

    The tag is now renamed as "node-api".
    
    PR-URL: #44190
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    legendecas authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    60de663 View commit details
    Browse the repository at this point in the history
  28. net: remove unused callback

    PR-URL: #44204
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    theanarkh authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    2a75bce View commit details
    Browse the repository at this point in the history
  29. assert: add assert.Snapshot

    PR-URL: #44095
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    fb5884a View commit details
    Browse the repository at this point in the history
  30. doc: add MoLow to collaborators

    PR-URL: #44214
    Fixes: #44120
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    a127c48 View commit details
    Browse the repository at this point in the history
  31. deps: upgrade npm to 8.17.0

    PR-URL: #44205
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    npm-cli-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c9602fa View commit details
    Browse the repository at this point in the history
  32. assert: add getCalls and reset to callTracker

    PR-URL: #44191
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    83a7ffe View commit details
    Browse the repository at this point in the history
  33. src: iterate over base objects to prepare for snapshot

    Instead of iterating over the bindings, iterate over the base
    objects that are snapshottable. This allows us to snapshot
    base objects that are not bindings. In addition this refactors
    the InternalFieldInfo class to eliminate potential undefined
    behaviors, and renames it to InternalFieldInfoBase.
    The {de}serialize callbacks now expect a InternalFieldInfo struct
    nested in Snapshotable classes that can be used to carry
    serialization data around. This allows us to create structs
    inheriting from InternalFieldInfo for Snapshotable objects
    that need custom fields.
    
    PR-URL: #44192
    Refs: #37476
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3359c2c View commit details
    Browse the repository at this point in the history
  34. test: use mustSucceed instead of mustCall with assert.ifError

    PR-URL: #44196
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    fossamagna authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b0e3e69 View commit details
    Browse the repository at this point in the history
  35. doc: improved building doc for Android

    PR-URL: #44166
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    MeowShe authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    46c92c1 View commit details
    Browse the repository at this point in the history
  36. crypto: fix webcrypto operation errors to be OperationError

    PR-URL: #44171
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    90f3c5e View commit details
    Browse the repository at this point in the history
  37. crypto: fix webcrypto generateKey() AES key length validation error

    PR-URL: #44170
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    a60ae67 View commit details
    Browse the repository at this point in the history
  38. crypto: fix webcrypto EC key namedCurve validation errors

    PR-URL: #44172
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    02bcf13 View commit details
    Browse the repository at this point in the history
  39. crypto: fix webcrypto deriveBits validations

    PR-URL: #44173
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    05bf817 View commit details
    Browse the repository at this point in the history
  40. crypto: allow zero-length secret KeyObject

    PR-URL: #44201
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    521ad0e View commit details
    Browse the repository at this point in the history
  41. crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2

    PR-URL: #44201
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    45dcd5c View commit details
    Browse the repository at this point in the history
  42. build: enable pointer authentication for branch protection on arm64

    PR-URL: #43200
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    jgowdy-godaddy authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    bb346ea View commit details
    Browse the repository at this point in the history
  43. errors: refactor to use optional chaining

    PR-URL: #44184
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    xtx1130 authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    fd80430 View commit details
    Browse the repository at this point in the history
  44. src: fix --heapsnapshot-near-heap-limit error hint

    PR-URL: #44216
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    legendecas authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ce5de6e View commit details
    Browse the repository at this point in the history
  45. meta: update AUTHORS

    PR-URL: #44231
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    40c0f55 View commit details
    Browse the repository at this point in the history
  46. test: mark connection leak test flaky on IBM i

    Mark `test-http-pipeline-requests-connection-leak` flaky on IBM i.
    
    PR-URL: #44215
    Refs: #43509
    Refs: #39683
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    richardlau authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ee394f3 View commit details
    Browse the repository at this point in the history
  47. tools: update lint-md-dependencies to rollup@2.77.3

    PR-URL: #44230
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3abea4d View commit details
    Browse the repository at this point in the history
  48. test: add filesystem check to test-fs-stat-date.mjs

    PR-URL: #44174
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    LiviaMedeiros authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    64300a6 View commit details
    Browse the repository at this point in the history
  49. deps: update corepack to 0.12.3

    PR-URL: #44229
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c18c646 View commit details
    Browse the repository at this point in the history
  50. test,crypto: update WebCryptoAPI WPT

    PR-URL: #44223
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    panva authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    2f2ea4b View commit details
    Browse the repository at this point in the history
  51. test: remove cjs loader from stack traces

    PR-URL: #44197
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    GeoffreyBooth authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    a82e768 View commit details
    Browse the repository at this point in the history
  52. src: remove usage on ScriptCompiler::CompileFunctionInContext

    V8 APIs like HostImportModuleDynamicallyCallback and
    ScriptCompiler::CompileFunction is moving away from ScriptOrModule.
    
    Replaces ScriptCompiler::CompileFunctionInContext with
    ScriptCompiler::CompileFunction to remove the usages on the optional
    out param ScriptOrModule.
    
    PR-URL: #44198
    Fixes: nodejs/node-v8#214
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    legendecas authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ceb62e5 View commit details
    Browse the repository at this point in the history
  53. test: reduce http-server-request-timeouts-mixed flakiness

    parallel/test-http-server-request-timeouts-mixed.js test was sometimes
    failing due to insufficient tolerance between the connection timeout
    checking interval, and the expected timeout specified in the test.
    
    This change makes the checking interval more frequent, and decouples
    the timeout for the check from the checking interval.
    
    PR-URL: #44169
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nicksia-vgw authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    900c4c0 View commit details
    Browse the repository at this point in the history
  54. doc: fix added version for readable.closed/destroyed

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    PR-URL: #44033
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MasterOdin authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    741402d View commit details
    Browse the repository at this point in the history
  55. stream: improve views validation on BYOBRequest

    - This throws if the view is zero-length when there is an active reader
    when using `ReadableStreamBYOBRequest.respondWithNewView()`.
    
    - By doing that, we can get all tests passed in
    `readable-byte-streams/bad-buffers-and-views.any.js`.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44155
    Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    daeyeon authored and danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    96c3373 View commit details
    Browse the repository at this point in the history
  56. 2022-08-16, Version 18.8.0 (Current)

    Notable changes:
    
    bootstrap: implement run-time user-land snapshots via --build-snapshot
    and --snapshot-blob
    
    This patch introduces `--build-snapshot` and `--snapshot-blob` options
    for creating and using user land snapshots.
    
    To generate a snapshot using snapshot.js as an entry point and write
    the snapshot blob to snapshot.blob:
    
    ```bash
    echo "globalThis.foo = 'I am from the snapshot'" > snapshot.js
    node --snapshot-blob snapshot.blob --build-snapshot snapshot.js
    ```
    
    To restore application state from snapshot.blob, with index.js as the
    entry point script for the deserialized application:
    
    ```bash
    echo "console.log(globalThis.foo)" > index.js
    node --snapshot-blob snapshot.blob index.js
    ```
    
    Users can also use the `v8.startupSnapshot` API to specify an entry
    point at snapshot building time, thus avoiding the need of an additional
    entry script at deserialization time:
    
    ```bash
    echo "require('v8').startupSnapshot.setDeserializeMainFunction(() => console.log('I am from the snapshot'))" > snapshot.js
    node --snapshot-blob snapshot.blob --build-snapshot snapshot.js
    node --snapshot-blob snapshot.blob
    ```
    
    Contributed by Joyee Cheung in #38905
    
    Other notable changes:
    
    * crypto:
      * (SEMVER-MINOR) allow zero-length IKM in HKDF and in webcrypto PBKDF2
      (Filip Skokan) #44201
      * (SEMVER-MINOR) allow zero-length secret KeyObject (Filip Skokan) #44201
    * doc:
      * add MoLow to collaborators (Moshe Atlow) #44214
      * add ErickWendel to collaborators (Erick Wendel) #44088
    * http:
      * (SEMVER-MINOR) make idle http parser count configurable (theanarkh) #43974
    * net:
      * (SEMVER-MINOR) add local family (theanarkh) #43975
    * src:
      * (SEMVER-MINOR) add detailed embedder process initialization API (Anna
      Henningsen) #44121
      * (SEMVER-MINOR) print source map error source on demand (Chengzhong
      Wu) #43875
    * tls:
      * (SEMVER-MINOR) pass a valid socket on `tlsClientError` (Daeyeon
      Jeong) #44021
    * worker:
      * deprecate `--trace-atomics-wait` (Keyhan Vakil) #44093
    danielleadams committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    db0b9b6 View commit details
    Browse the repository at this point in the history