Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 10.2.154.15 #44294

Merged
merged 1 commit into from Aug 28, 2022
Merged

deps: patch V8 to 10.2.154.15 #44294

merged 1 commit into from Aug 28, 2022

Conversation

targos
Copy link
Member

@targos targos commented Aug 19, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 19, 2022
@targos targos added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. labels Aug 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 19, 2022

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 28, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 28, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/44294
✔  Done loading data for nodejs/node/pull/44294
----------------------------------- PR info ------------------------------------
Title      deps: patch V8 to 10.2.154.15 (#44294)
Author     Michaël Zasso  (@targos)
Branch     targos:v8-15 -> nodejs:main
Labels     v8 engine, fast-track, needs-ci, dont-land-on-v14.x, dont-land-on-v16.x
Commits    1
 - deps: patch V8 to 10.2.154.15
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/44294
Refs: https://github.com/v8/v8/compare/10.2.154.13...10.2.154.15
Reviewed-By: Richard Lau 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44294
Refs: https://github.com/v8/v8/compare/10.2.154.13...10.2.154.15
Reviewed-By: Richard Lau 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Jiawen Geng 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 19 Aug 2022 14:15:01 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44294#pullrequestreview-1078916969
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44294#pullrequestreview-1079492435
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/44294#pullrequestreview-1079521218
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44294#pullrequestreview-1079524904
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-08-20T14:23:52Z: https://ci.nodejs.org/job/node-test-pull-request/46089/
   ℹ  Last V8 CI on 2022-08-19T16:26:57Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4818/
- Querying data for job/node-test-pull-request/46089/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2942024281

@targos targos added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 28, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3a6003a into nodejs:main Aug 28, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3a6003a

@targos targos deleted the v8-15 branch August 28, 2022 06:49
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
Refs: v8/v8@10.2.154.13...10.2.154.15
PR-URL: #44294
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
Refs: v8/v8@10.2.154.13...10.2.154.15
PR-URL: nodejs#44294
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants