Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix description of named exports detection #44296

Closed
wants to merge 1 commit into from

Conversation

csr632
Copy link

@csr632 csr632 commented Aug 19, 2022

The tool used to do named exports detection should be cjs-module-lexer, not esm-module-lexer.
Reference: https://github.com/nodejs/node/blob/5e57d24d325f0aea74394f78ebdc06857cca77b1/doc/api/esm.md

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 19, 2022
@richardlau
Copy link
Member

This overlaps with #44262.

@JakobJingleheimer
Copy link
Contributor

Thanks for the contribution! As Richard mentioned, there is already an approved PR fixing this.

P.S. The links at the bottom of the doc file must be in alphabetical order. The current error is misleading:

Unordered reference ("cjs-module-lexer" should be before "the full specifier path")

The new link you added must indeed be listed above the one immediately above it, but it actually must be far above.

@csr632
Copy link
Author

csr632 commented Aug 20, 2022

Thanks for the review! I am closing this PR.

@csr632 csr632 closed this Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants