Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.8.0 release proposal #44353

Merged
merged 177 commits into from Aug 24, 2022
Merged

v18.8.0 release proposal #44353

merged 177 commits into from Aug 24, 2022

Commits on Aug 21, 2022

  1. src: split property helpers from node::Environment

    PR-URL: #44056
    Backport-PR-URL: #44251
    Refs: #42528
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    legendecas authored and ruyadorno committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    68ee8e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. http: do not leak error listeners

    PR-URL: #43587
    Fixes: #43548
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    ShogunPanda authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8c2d19b View commit details
    Browse the repository at this point in the history
  2. esm: move package config helpers

    PR-URL: #43967
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    GeoffreyBooth authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e072c3a View commit details
    Browse the repository at this point in the history
  3. tools: add verbose flag to find-inactive-collaborators

    PR-URL: #43964
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1175d90 View commit details
    Browse the repository at this point in the history
  4. doc: add missing test runner option

    PR-URL: #43989
    Refs: #43554
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    7af55db View commit details
    Browse the repository at this point in the history
  5. test: change misleading variable name

    The return value of getPrime() is not a private key in any way.
    
    Refs: nodejs/node-v0.x-archive#2638
    
    PR-URL: #43990
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3c8037a View commit details
    Browse the repository at this point in the history
  6. doc: fix typos in test.md

    PR-URL: #43997
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1b32830 View commit details
    Browse the repository at this point in the history
  7. test: fix test-cluster-concurrent-disconnect

    The error code, `ECONNRESET`, is observed on linux.
    This commit adds it as an expected error code.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    
    PR-URL: #43961
    Refs: https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutintl_x64/32901/testReport/junit/(root)/test/parallel_test_cluster_concurrent_disconnect/
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9244d6d View commit details
    Browse the repository at this point in the history
  8. test: reduce loop times for preventing test from timeout

    PR-URL: #43981
    Refs: nodejs/reliability#331
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2cab7bb View commit details
    Browse the repository at this point in the history
  9. test_runner: validate concurrency option

    PR-URL: #43976
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    51a0310 View commit details
    Browse the repository at this point in the history
  10. net: add local family

    PR-URL: #43975
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b6b632c View commit details
    Browse the repository at this point in the history
  11. test: remove test-gc-http-client-timeout from flaky list

    PR-URL: #43971
    Refs: #43949
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    F3n67u authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d964b30 View commit details
    Browse the repository at this point in the history
  12. deps: cherry-pick 00704f5a from V8 upstream

    Original commit message:
    
        Add more efficient API for accesssing ArrayBuffer raw data
    
        Raw data access is already possible via GetBackingStore()->GetData().
        This API exposes a more efficient way for accessing
        JSArrayBuffer::backing_store (which, despite the confusing name, is no
        the BackingStore but its raw data pointer).
    
        Bug: v8:10343
        Change-Id: I695cea91e2c3de75ce6c86bac6e413ce6617958b
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764341
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#81745}
    
    Refs: v8/v8@00704f5
    Refs: #32226
    
    PR-URL: #43921
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a0c5783 View commit details
    Browse the repository at this point in the history
  13. lib: add Promise methods to avoid-prototype-pollution lint rule

    PR-URL: #43849
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    94912bb View commit details
    Browse the repository at this point in the history
  14. doc: fix typo in packages.md

    "previous" read like it should be "previously"
    
    PR-URL: #44005
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    jtoar authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    72a9ecf View commit details
    Browse the repository at this point in the history
  15. test_runner: graceful termination on --test only

    PR-URL: #43977
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    04fdc3e View commit details
    Browse the repository at this point in the history
  16. http: reuse socket only when it is drained

    Ensuring every request is assigned to a drained socket or nothing.
    Because is has no benifit for a request to be attached to a non
    drained socket and it prevents the request from being assigned to
    a drained one, which might occur soon or already in the free pool
    We achieve this by claiming a socket as free only when the socket
    is drained.
    
    PR-URL: #43902
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    ywave620 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    5dc39a1 View commit details
    Browse the repository at this point in the history
  17. src: remove unnecessary cast in crypto_sig.cc

    ByteSource::Allocated accepts a void pointer now, so we do not need to
    cast the argument to a char pointer.
    
    Refs: #43202
    
    PR-URL: #44001
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4603977 View commit details
    Browse the repository at this point in the history
  18. doc: list supported MODP groups explicitly

    Instead of referring users to perl to find information about supported
    MODP groups in crypto_groups.h, explicitly list the groups with their
    respective strengths and with references to the defining RFC sections.
    
    Refs: #43896
    
    PR-URL: #43986
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    374b776 View commit details
    Browse the repository at this point in the history
  19. src,lib: print source map error source on demand

    The source context is not prepended to the value of the `stack` property
    when the source map is not enabled. Rather than prepending the error
    source context to the value of the `stack` property unconditionally,
    this patch aligns the behavior and only prints the source context when
    the error is not handled by userland (e.g. fatal errors).
    
    Also, this patch fixes that when source-map support is enabled, the
    error source context is not pointing to where the error was thrown.
    
    PR-URL: #43875
    Fixes: #43186
    Fixes: #41541
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4249276 View commit details
    Browse the repository at this point in the history
  20. lib: add missing env vars to --help

    PR-URL: #43492
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    cola119 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    617ea4a View commit details
    Browse the repository at this point in the history
  21. doc: add missing env vars to man page

    PR-URL: #43492
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    cola119 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    222ecd6 View commit details
    Browse the repository at this point in the history
  22. doc: remove old reference from crypto/README.md

    The referenced header file does not exist anymore.
    
    Refs: #43896
    
    PR-URL: #44012
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d23dfa4 View commit details
    Browse the repository at this point in the history
  23. src: fix typo in src/README.md

    PR-URL: #44009
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    addaleax authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9763e2f View commit details
    Browse the repository at this point in the history
  24. test_runner: fix top level describe queuing

    PR-URL: #43998
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    50c854b View commit details
    Browse the repository at this point in the history
  25. deps: upgrade npm to 8.15.1

    PR-URL: #44013
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    npm-cli-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b7aaf3d View commit details
    Browse the repository at this point in the history
  26. src: improve SPKAC::ExportChallenge()

    Declare buf as an unsigned char to get rid of the reinterpret_cast and
    do not ignore the return value of ASN1_STRING_TO_UTF8. This also removes
    the need to call strlen() on the result.
    
    PR-URL: #44002
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    cc6e0fc View commit details
    Browse the repository at this point in the history
  27. src: fix to use replacement character

    PR-URL: #43999
    Fixes: #43962
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    cola119 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    728e18e View commit details
    Browse the repository at this point in the history
  28. test: refactor ESM tests to improve performance

    PR-URL: #43784
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    JakobJingleheimer authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b19564b View commit details
    Browse the repository at this point in the history
  29. http: make idle http parser count configurable

    PR-URL: #43974
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a2cd8b3 View commit details
    Browse the repository at this point in the history
  30. src,fs: refactor duplicated code in fs.readdir

    `AfterScanDirWithTypes` is almost same as `AfterScanDir` except for
    handling the `with file types` option. This merges the two functions
    into one.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    
    PR-URL: #43204
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ecf8218 View commit details
    Browse the repository at this point in the history
  31. meta: shorten PowerShell snippet for bug-report template

    PR-URL: #44011
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    NicoNekoru authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    697dbfb View commit details
    Browse the repository at this point in the history
  32. src: fix bug in GetErrorSource()

    Refs: #43875
    
    PR-URL: #44019
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b90b8ab View commit details
    Browse the repository at this point in the history
  33. doc: claim ABI version for Electron 21

    PR-URL: #44034
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    VerteDinde authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1b9537b View commit details
    Browse the repository at this point in the history
  34. doc: fix code examples in crypto.md

    PR-URL: #44053
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2ae5d85 View commit details
    Browse the repository at this point in the history
  35. test_runner: add before/after/each hooks

    PR-URL: #43730
    Fixes: #43403
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c3fa82f View commit details
    Browse the repository at this point in the history
  36. src: use a typed array internally for process._exiting

    This would prevent manual writes to the _exiting JS property on the
    process object by passing the data directly via a typed array for
    performance.
    
    This change partially addresses this TODO:
    https://github.com/nodejs/node/blob/3d575a4f1bd197c3ce669758a2a3c763462a883a/src/api/hooks.cc#L68-L71
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #43883
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    RaisinTen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    04bcdf6 View commit details
    Browse the repository at this point in the history
  37. doc: clarify part of onboarding guide regarding adding to teams

    There are a number of teams (for example, the build team) which require
    more than just showing interest as a prerequisite for being added, so
    this change adds a link to the set of subsystem teams where new
    Collaborators can be added directy.
    
    Also, the doc didn't actually mention if the new Collaborator should be
    added to the team. This change also clarifies that.
    
    Refs: nodejs/build#3003
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #44024
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RaisinTen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    7f7a0eb View commit details
    Browse the repository at this point in the history
  38. tools: update lint-md-dependencies to rollup@2.77.2

    PR-URL: #44064
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3eacf25 View commit details
    Browse the repository at this point in the history
  39. test: fix internet/test-inspector-help-page

    This gets the test to use its own `https.agent` instead of the default
    one.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    
    PR-URL: #44025
    Refs: #43522
    Refs: https://github.com/nodejs/node/actions/workflows/test-internet.yml
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    40e2ca7 View commit details
    Browse the repository at this point in the history
  40. doc: add kvakil to triagers

    I am volunteering to be a triager. I'd like to become more involved,
    help users with their issues, and eventually become a collaborator.
    
    I've understood & agree to the code of conduct.
    
    PR-URL: #43996
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1d6029a View commit details
    Browse the repository at this point in the history
  41. test_runner: empty pending tests queue post running

    PR-URL: #44059
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0d00747 View commit details
    Browse the repository at this point in the history
  42. doc: copyedit test.md

    PR-URL: #44061
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    76011dd View commit details
    Browse the repository at this point in the history
  43. build: skip test-internet run on forks

    Do not run test-internet scheduled GitHub Action on forks.
    
    PR-URL: #44054
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ea48c56 View commit details
    Browse the repository at this point in the history
  44. net,tls: pass a valid socket on tlsClientError

    On the 'tlsClientError' event, the `tlsSocket` instance is passed as
    `closed` status. Thus, users can't get information such as `remote
    address`, `remoteFamily`, and so on.
    
    This adds a flag to close a socket after emitting an `error` event.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44021
    Fixes: #43963
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3ba75b3 View commit details
    Browse the repository at this point in the history
  45. doc: update collaborator email

    Updating my email on the collaborator section of README.
    
    PR-URL: #44044
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    fe83d51 View commit details
    Browse the repository at this point in the history
  46. doc: add ErickWendel to collaborators

    Fixes: #43755
    PR-URL: #44088
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    ErickWendel authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    58f2739 View commit details
    Browse the repository at this point in the history
  47. meta: update AUTHORS

    PR-URL: #44065
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a996f53 View commit details
    Browse the repository at this point in the history
  48. test_runner: verbous error when entire test tree is canceled

    PR-URL: #44060
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d8749c3 View commit details
    Browse the repository at this point in the history
  49. build: allow test-internet on forks if not scheduled

    Refs: #44054 (comment)
    PR-URL: #44073
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Trott authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ec1b31e View commit details
    Browse the repository at this point in the history
  50. src: nest namespace report in namespace node

    PR-URL: #44069
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c4783e3 View commit details
    Browse the repository at this point in the history
  51. src: remove usages of GetBackingStore in startup

    This removes all usages of GetBackingStore in startup. See the linked
    issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44078
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    38cdb1f View commit details
    Browse the repository at this point in the history
  52. src: remove usages of GetBackingStore in WASI

    This removes all usages of GetBackingStore in WASI. See the linked issue
    for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44077
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a54e4d4 View commit details
    Browse the repository at this point in the history
  53. src: remove usages of GetBackingStore in modules

    This removes all usages of GetBackingStore in modules. See the linked
    issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44076
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    cddf3ed View commit details
    Browse the repository at this point in the history
  54. src: remove usages of GetBackingStore in node-api

    This removes all usages of GetBackingStore in `node-api`. See the linked
    issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44075
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8e1b7e2 View commit details
    Browse the repository at this point in the history
  55. src: remove unowned usages of GetBackingStore

    This removes all usages of GetBackingStore without any entries in the
    `CODEOWNERS` file. For the most part this is a pretty straightforward
    review; except `SPREAD_BUFFER_ARG` and the changes to `CopyArrayBuffer`.
    
    See the linked issue for an explanation.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44080
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a2022e5 View commit details
    Browse the repository at this point in the history
  56. meta: add codeowner for src/node_snapshot*

    PR-URL: #44113
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e0efd9a View commit details
    Browse the repository at this point in the history
  57. src,test: fix typos

    * src: fix typo in `src/node_messaging.h` (`postMesssage` ->
      `postMessage`).
    * test/es-module: fix typo in `test-cjs-exports.js` (`eror` -> `error`).
    
    PR-URL: #44110
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    sadikkuzu authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1dabdbf View commit details
    Browse the repository at this point in the history
  58. doc: update repository list in onboarding doc

    LTS repo is now Release.
    
    readable-stream is important but a bit of a specialized topic. The
    others listed here are of general interest.
    
    PR-URL: #44089
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Trott authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0223603 View commit details
    Browse the repository at this point in the history
  59. doc: clarify tls.tlsSocket.getCipher().version

    The getCipher() returns a tuple that includes protocol version string.
    This string refers to the minimum protocol version string, as per
    documentation. What is missing is a reference to the documentation
    where to get the negotiated cipher for the socket connection and
    a clearer example.
    
    Fixes: #43406
    PR-URL: #44086
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    AdamMajer authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    46f8fb8 View commit details
    Browse the repository at this point in the history
  60. net, dns: socket should handle its output as input

    As a consequence of #43014 ,
    server sockets and others, once connected, report string family
    names. But when feeding these to Socket.connect(), it passes
    these to host resolution with a string for family while a numeric
    family is expected internally. This results in wrong hints flags
    to be set and resolution to fail.
    
    As solution, is to add ability to handle both numeric and string
    family names when doing lookup and connect.
    
    Fixes: #44003
    PR-URL: #44083
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    AdamMajer authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c3d8756 View commit details
    Browse the repository at this point in the history
  61. src,buffer: remove unused chars_written parameter

    This parameter was always being set to `nullptr` by its callers, either
    explicitly or implicitly via the default argument. It was also buggy, as
    in some cases it wouldn't be written to, potentially leaking stack
    memory (see the early returns in `StringBytes::WriteUCS2`). Remove it
    entirely.
    
    PR-URL: #44092
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9990dc7 View commit details
    Browse the repository at this point in the history
  62. test_runner: refactor to use more primordials

    PR-URL: #44062
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8ed3939 View commit details
    Browse the repository at this point in the history
  63. doc,worker: deprecate --trace-atomics-wait

    V8 has asked if it possible to remove the functionality underlying
    `--trace-atomics-wait`. Let's start with a documentation-only
    deprecation.
    
    PR-URL: #44093
    Refs: #42982
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    da7bc5a View commit details
    Browse the repository at this point in the history
  64. doc: add theanarkh to collaborators

    Fixes: #44006
    PR-URL: #44131
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8c26daf View commit details
    Browse the repository at this point in the history
  65. deps: upgrade base64 to dc6a41ce36e

    Fixes: #43894
    PR-URL: #44032
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    mscdex authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    116dccc View commit details
    Browse the repository at this point in the history
  66. bootstrap: support more builtins in the embedded code cache

    This patch:
    
    - Make NativeModuleLoader::LookupAndCompile() detect parameters based
      on module IDs. This allows us to compile more builtins when
      generating the embedded bootstrap, including
      - internal/per_context/*
      - internal/bootstrap/*
      - internal/main/*
    - Move pre_execution.js to lib/internal/process as it needs to be
      compiled as a regular built-in module, unlike other scripts
      in lib/internal/bootstrap
    - Move markBootstrapComplete() to the performance binding instead of
      making it a function-wrapper-based global to reduce number of
      special cases.
    
    PR-URL: #44018
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e7d101f View commit details
    Browse the repository at this point in the history
  67. esm: fix loader hooks accepting too many arguments

    PR-URL: #44109
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    JakobJingleheimer authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    5e9c197 View commit details
    Browse the repository at this point in the history
  68. doc: remove unused code in call tracker example

    This function appears to be unused, so remove it.
    
    PR-URL: #44127
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    cjihrig authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    cb7a9e7 View commit details
    Browse the repository at this point in the history
  69. bootstrap: turn on FunctionCodeHandling::kKeep in the snapshot builder

    To improve startup performance.
    
    PR-URL: #44104
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    123b2d6 View commit details
    Browse the repository at this point in the history
  70. stream: update TextEncoderStream to align the latest spec

    PR-URL: #44101
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    cola119 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2f904bc View commit details
    Browse the repository at this point in the history
  71. src: remove usages of GetBackingStore in crypto

    This removes all usages of GetBackingStore in `crypto`. See the
    linked issue for an explanation.
    
    Note: I am not sure of the lifetime semantics intended by
    `ArrayBufferOrViewContents` -- I am pretty sure it is correct based on
    a manual audit of the callsites, but please ensure that it is correct.
    
    Refs: #32226
    Refs: #43921
    PR-URL: #44079
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4755ad5 View commit details
    Browse the repository at this point in the history
  72. module: protect against prototype mutation

    Ensures that mutating the `Object` prototype does not influence the
    parsing of `package.json` files.
    
    PR-URL: #44007
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    05802c2 View commit details
    Browse the repository at this point in the history
  73. lib: pass env variables to child process on z/OS

    PR-URL: #42255
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    alexcfyung authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c02bbdd View commit details
    Browse the repository at this point in the history
  74. deps: upgrade npm to 8.16.0

    PR-URL: #44119
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    npm-cli-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    194587e View commit details
    Browse the repository at this point in the history
  75. deps: remove unnecessary file

    PR-URL: #44133
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    mscdex authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    763b956 View commit details
    Browse the repository at this point in the history
  76. test: tune down parallelism for some flaky tests

    These tests seem to timeout quite often. I don't know why, but one
    possible reason is that they are starting a lot of threads. It seems
    that tests in `test/parallel` are assumed to only start one thread each,
    so having 11 threads running at a time feels like a lot.
    
    It also seems that these tests fail in a correlated fashion: take a look
    at [this reliability report][]. The failures all occur on the same build
    machines on the same PRs. This suggests to me some sort of CPU
    contention.
    
    [this reliability report]: nodejs/reliability#334
    
    On my Linux machine decreasing the parallelism & iterations here reduce
    the `user` time from ~11.5 seconds to ~2 seconds, depending on the test.
    I have seen these tests take 30-60 seconds on CI (Alpine in particular).
    
    I went back to the diffs that introduced that introduced these changes
    and verified that they failed at least 90% of the time with the reduced
    iteration count, which feels sufficient.
    
    Refs: #43499
    Refs: #43084
    PR-URL: #44090
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    86bbd5e View commit details
    Browse the repository at this point in the history
  77. http: trace http request / response

    PR-URL: #44102
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c340344 View commit details
    Browse the repository at this point in the history
  78. deps: V8: cherry-pick 9861ce1deae2

    Original commit message:
    
        PPC: pass a scratch reg when using register_location
    
        Change-Id: I43e4a4cadc60e958d6c9d80e725a49a3e36d8ba9
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3797832
        Reviewed-by: Junliang Yan <junyan@redhat.com>
        Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
        Cr-Commit-Position: refs/heads/main@{#82146}
    
    Fixes: #44055
    PR-URL: #44115
    Refs: v8/v8@9861ce1
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    miladfarca authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    52a516a View commit details
    Browse the repository at this point in the history
  79. src: prevent copying ArrayBufferViewContents

    It is error-prone to copy or heap-allocate `ArrayBufferViewContents`,
    because you might accidentally cause it to exceed the lifetime of its
    argument. Let's make it impossible to do so. Fortunately we were not
    doing so anywhere already, so this diff is purely defensive.
    
    Refs: #44079 (comment)
    PR-URL: #44091
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    960a209 View commit details
    Browse the repository at this point in the history
  80. tools: update undici CPE in vuln checking script

    This changes the search method for `undici` on the NVD database.
    Before, since `undici` did not have a CPE assigned, the search
    was by keyword. Now that a CPE was assigned, it is used to query
    for new vulnerabilities.
    
    PR-URL: #44128
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    facutuesca authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b252f38 View commit details
    Browse the repository at this point in the history
  81. src,lib: print prinstine source when source map source not found

    Print unmapped source lines when the source map source is not
    found. Error stacks should be correctly mapped even when the
    source is absent.
    
    PR-URL: #44052
    Refs: #44019
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ee6412a View commit details
    Browse the repository at this point in the history
  82. doc: add performance note to --enable-source-maps docs

    PR-URL: #43817
    Reviewed-By: Ben Coe <bencoe@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    saurabhdaware authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    fb11643 View commit details
    Browse the repository at this point in the history
  83. test: s390x z15 accelerated zlib fixes

    Modern s390x x15 has accelerated zlib operations on the CPU. Many
    distros currently have patches to take advantage of this feature. One
    side-effect of these patches is that compression routine is no longer
    deterministic as with software. Interruption to input produces
    different compressed results. Invalid input can result in processor
    fault.
    
    PR-URL: #44117
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    AdamMajer authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    f1b5f93 View commit details
    Browse the repository at this point in the history
  84. doc: add Retry CI in collaborator guide

    PR-URL: #44130
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    LiviaMedeiros authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0fffc24 View commit details
    Browse the repository at this point in the history
  85. build: optimized and fixed building configuration to Android

    PR-URL: #44016
    Reviewed-By: Yash Ladha <yash@yashladha.in>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Christian Clauss <cclauss@me.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    MeowShe authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c975c4f View commit details
    Browse the repository at this point in the history
  86. test: remove test-http-client-response-timeout flaky designation

    The issue was fixed by #43890.
    
    Fixes: #43680
    PR-URL: #44145
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    lpinca authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e5113fa View commit details
    Browse the repository at this point in the history
  87. test: move test-vm-break-on-sigint to sequential

    This PR moves `test-vm-break-on-sigint.js` to sequential, following the
    other PRs I have made to move CPU intensive tests into sequential. The
    test has already been tuned to do less iterations in a previous PR.
    However it is still causing ~7% of build failures. The timeouts seem
    highly correlated with other tests which spawn a bunch of threads also
    failing, see for example the [first Jenkins failure][] and the [last
    Jenkins failure][].
    
    [first Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45756/
    [last Jenkins failure]: https://ci.nodejs.org/job/node-test-pull-request/45837/
    
    Refs: #44090
    Refs: #43981
    Refs: nodejs/reliability#337
    PR-URL: #44140
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e17117d View commit details
    Browse the repository at this point in the history
  88. test: deflake gc-http-client tests by restricting number of requests

    sequential/test-gc-http-client tests were sometimes failing due to
    a non-deterministic number of requests being created, causing the
    test to fail on some systems with a "ECONNRESET" error caused by
    too many concurrent connections
    
    Fixes: #43638
    PR-URL: #44146
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nicksia-vgw authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    86a7fb0 View commit details
    Browse the repository at this point in the history
  89. test: move tests with many workers to sequential

    These tests spawn many workers, which may be CPU intensive causing
    timeouts (see the referenced PR for more details). Let's move them
    to sequential.
    
    Refs: #44090
    PR-URL: #44139
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    kvakil authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    70267a0 View commit details
    Browse the repository at this point in the history
  90. meta: update AUTHORS

    PR-URL: #44161
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c59dc7a View commit details
    Browse the repository at this point in the history
  91. tools: update lint-md-dependencies to @rollup/plugin-commonjs@22.0.2

    PR-URL: #44160
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6be7e6d View commit details
    Browse the repository at this point in the history
  92. deps: update corepack to 0.12.2

    PR-URL: #44159
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a92d90b View commit details
    Browse the repository at this point in the history
  93. build: add workflow to label flaky-test platform

    This workflow adds platform labels on `flaky-test` issues to make it
    easier and more reliable for someone to use labels to (for example)
    find all flaky tests on SmartOS or all flaky tests on FreeBSD.
    
    PR-URL: #44042
    Fixes: #43854
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    RafaelGSS authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    fecec4d View commit details
    Browse the repository at this point in the history
  94. tools: update eslint to 8.21.0

    PR-URL: #44162
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    873941a View commit details
    Browse the repository at this point in the history
  95. deps: update undici to 5.8.1

    PR-URL: #44158
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d09bc54 View commit details
    Browse the repository at this point in the history
  96. esm: do not bind loader hook functions

    PR-URL: #44122
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a6dccc9 View commit details
    Browse the repository at this point in the history
  97. test: update console web platform tests

    PR-URL: #44100
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    79445cb View commit details
    Browse the repository at this point in the history
  98. test: update hr-time web platform tests

    PR-URL: #44100
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    537d52f View commit details
    Browse the repository at this point in the history
  99. test: update wasm/jsapi web platform tests

    PR-URL: #44100
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6b84451 View commit details
    Browse the repository at this point in the history
  100. lib: fix diagnostics channel

    PR-URL: #44154
    Fixes: #44143
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    04007f2 View commit details
    Browse the repository at this point in the history
  101. http: fix error message when specifying headerTimeout for createServer

    This change fixes the message on the error received when calling
    http.createServer(...) with a header timeout greater than the request
    timeout is incorrect.
    
    The validation requires that the header timeout is lower than the
    request timeout, but the error message asks for the opposite.
    
    PR-URL: #44163
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    nicksia-vgw authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    340ca4d View commit details
    Browse the repository at this point in the history
  102. deps: update undici to 5.8.2

    PR-URL: #44187
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    818271c View commit details
    Browse the repository at this point in the history
  103. test: update wpt url status

    PR-URL: #44175
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cola119 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b2a15b6 View commit details
    Browse the repository at this point in the history
  104. events: use bitset to save memory

    PR-URL: #43700
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mabaasit authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d57178c View commit details
    Browse the repository at this point in the history
  105. test: update WPT runner

    PR-URL: #43455
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    11f74e7 View commit details
    Browse the repository at this point in the history
  106. doc: fix typo in diagnostics_channel

    The diagnostics_channel Channel class description had
    a typo.
    
    PR-URL: #44199
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    evanlucas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    721639a View commit details
    Browse the repository at this point in the history
  107. perf_hooks: fix gc elapsed time

    PR-URL: #44058
    Refs: #44046
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b9fd240 View commit details
    Browse the repository at this point in the history
  108. doc: update tags in adding-new-napi-api.md

    The tag is now renamed as "node-api".
    
    PR-URL: #44190
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Qingyu Deng <i@ayase-lab.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    6bff14b View commit details
    Browse the repository at this point in the history
  109. net: remove unused callback

    PR-URL: #44204
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    aa7c053 View commit details
    Browse the repository at this point in the history
  110. assert: add assert.Snapshot

    PR-URL: #44095
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    126fbba View commit details
    Browse the repository at this point in the history
  111. doc: add MoLow to collaborators

    PR-URL: #44214
    Fixes: #44120
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4d26cb9 View commit details
    Browse the repository at this point in the history
  112. deps: upgrade npm to 8.17.0

    PR-URL: #44205
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    npm-cli-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b1590bb View commit details
    Browse the repository at this point in the history
  113. assert: add getCalls and reset to callTracker

    PR-URL: #44191
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0e20072 View commit details
    Browse the repository at this point in the history
  114. test: use mustSucceed instead of mustCall with assert.ifError

    PR-URL: #44196
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    fossamagna authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    beaf5f5 View commit details
    Browse the repository at this point in the history
  115. doc: improved building doc for Android

    PR-URL: #44166
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    MeowShe authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    f39a051 View commit details
    Browse the repository at this point in the history
  116. crypto: fix webcrypto operation errors to be OperationError

    PR-URL: #44171
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ad8ef3a View commit details
    Browse the repository at this point in the history
  117. crypto: fix webcrypto generateKey() AES key length validation error

    PR-URL: #44170
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    81e1ec4 View commit details
    Browse the repository at this point in the history
  118. crypto: fix webcrypto EC key namedCurve validation errors

    PR-URL: #44172
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4c902be View commit details
    Browse the repository at this point in the history
  119. crypto: fix webcrypto deriveBits validations

    PR-URL: #44173
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ac2b10e View commit details
    Browse the repository at this point in the history
  120. crypto: allow zero-length secret KeyObject

    PR-URL: #44201
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    07d90c8 View commit details
    Browse the repository at this point in the history
  121. crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2

    PR-URL: #44201
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    1c0d66e View commit details
    Browse the repository at this point in the history
  122. build: enable pointer authentication for branch protection on arm64

    PR-URL: #43200
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    jgowdy-godaddy authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2ae2828 View commit details
    Browse the repository at this point in the history
  123. errors: refactor to use optional chaining

    PR-URL: #44184
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    xtx1130 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    37a9d7a View commit details
    Browse the repository at this point in the history
  124. src: fix --heapsnapshot-near-heap-limit error hint

    PR-URL: #44216
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4e1ffd9 View commit details
    Browse the repository at this point in the history
  125. meta: update AUTHORS

    PR-URL: #44231
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2c72ded View commit details
    Browse the repository at this point in the history
  126. test: mark connection leak test flaky on IBM i

    Mark `test-http-pipeline-requests-connection-leak` flaky on IBM i.
    
    PR-URL: #44215
    Refs: #43509
    Refs: #39683
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    richardlau authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9755b1f View commit details
    Browse the repository at this point in the history
  127. tools: update lint-md-dependencies to rollup@2.77.3

    PR-URL: #44230
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a3cc8ce View commit details
    Browse the repository at this point in the history
  128. test: add filesystem check to test-fs-stat-date.mjs

    PR-URL: #44174
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    LiviaMedeiros authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e373144 View commit details
    Browse the repository at this point in the history
  129. deps: update corepack to 0.12.3

    PR-URL: #44229
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a269972 View commit details
    Browse the repository at this point in the history
  130. test,crypto: update WebCryptoAPI WPT

    PR-URL: #44223
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    panva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8216434 View commit details
    Browse the repository at this point in the history
  131. test: remove cjs loader from stack traces

    PR-URL: #44197
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    GeoffreyBooth authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    f5e2f6c View commit details
    Browse the repository at this point in the history
  132. src: remove usage on ScriptCompiler::CompileFunctionInContext

    V8 APIs like HostImportModuleDynamicallyCallback and
    ScriptCompiler::CompileFunction is moving away from ScriptOrModule.
    
    Replaces ScriptCompiler::CompileFunctionInContext with
    ScriptCompiler::CompileFunction to remove the usages on the optional
    out param ScriptOrModule.
    
    PR-URL: #44198
    Fixes: nodejs/node-v8#214
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    9614907 View commit details
    Browse the repository at this point in the history
  133. test: reduce http-server-request-timeouts-mixed flakiness

    parallel/test-http-server-request-timeouts-mixed.js test was sometimes
    failing due to insufficient tolerance between the connection timeout
    checking interval, and the expected timeout specified in the test.
    
    This change makes the checking interval more frequent, and decouples
    the timeout for the check from the checking interval.
    
    PR-URL: #44169
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nicksia-vgw authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    b4224dd View commit details
    Browse the repository at this point in the history
  134. doc: fix added version for readable.closed/destroyed

    Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
    PR-URL: #44033
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MasterOdin authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8c1fe86 View commit details
    Browse the repository at this point in the history
  135. stream: improve views validation on BYOBRequest

    - This throws if the view is zero-length when there is an active reader
    when using `ReadableStreamBYOBRequest.respondWithNewView()`.
    
    - By doing that, we can get all tests passed in
    `readable-byte-streams/bad-buffers-and-views.any.js`.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44155
    Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c079abe View commit details
    Browse the repository at this point in the history
  136. doc: add cola119 to collaborators

    Fixes: #44123
    
    PR-URL: #44248
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    cola119 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e8916fa View commit details
    Browse the repository at this point in the history
  137. test: move "errors" test to "parallel"

    PR-URL: #44233
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    targos authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a02492f View commit details
    Browse the repository at this point in the history
  138. report: skip report if uncaught exception is handled

    If the exception is handled by the userland
    process#uncaughtException handler, reports should not be generated
    repetitively as the process may continue to run.
    
    PR-URL: #44208
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c842ab3 View commit details
    Browse the repository at this point in the history
  139. http: add max for http keepalive

    PR-URL: #44217
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    851264c View commit details
    Browse the repository at this point in the history
  140. tools: update lint-md-dependencies to rollup@2.78.0

    PR-URL: #44244
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    87f75a2 View commit details
    Browse the repository at this point in the history
  141. trace_events: add example

    PR-URL: #43253
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2cf3ce8 View commit details
    Browse the repository at this point in the history
  142. tls: use logical OR operator

    Use the logical OR operator instead of the ternary operator where
    applicable.
    
    PR-URL: #44236
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    VoltrexKeyva authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    ecf7b07 View commit details
    Browse the repository at this point in the history
  143. tools: update ESLint to 8.22.0

    PR-URL: #44243
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    lpinca authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    36b39db View commit details
    Browse the repository at this point in the history
  144. dgram: add dgram send queue info

    PR-URL: #44149
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    theanarkh authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    19557ad View commit details
    Browse the repository at this point in the history
  145. typings: add JSDoc for internal/validators

    PR-URL: #44181
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    anonrig authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    2efce0f View commit details
    Browse the repository at this point in the history
  146. meta: update web streams in label-pr-config

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44235
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    f7be92f View commit details
    Browse the repository at this point in the history
  147. test: update Web Streams WPT

    This updates the tests and the status file via
    running `git node wpt streams`.
    
    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44234
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    7b6126a View commit details
    Browse the repository at this point in the history
  148. lib: refactor to avoid prototype pollution

    PR-URL: #43474
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8cfc8b0 View commit details
    Browse the repository at this point in the history
  149. deps: upgrade npm to 8.18.0

    PR-URL: #44263
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    npm-cli-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    bce8041 View commit details
    Browse the repository at this point in the history
  150. stream: fix isDetachedBuffer validations

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    PR-URL: #44114
    Refs: #43866
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    daeyeon authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a3ac445 View commit details
    Browse the repository at this point in the history
  151. src: avoid copying BaseObjectPtrs in loop

    While copying BaseObjectPtrs is cheap, it is not a no-op, so it is best
    to iterate over references to BaseObjectPtrs only.
    
    PR-URL: #44270
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d2dce59 View commit details
    Browse the repository at this point in the history
  152. doc,report: document special filenames

    Filenames `stdout` and `stderr` have special meanings when writing
    the report.
    
    PR-URL: #44257
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e8441a2 View commit details
    Browse the repository at this point in the history
  153. src: extract common context embedder tag checks

    Extract common context embedder tag checks to ContextEmbedderTag so
    that verifying if a context is a node context doesn't need to access
    private members of node::Environment.
    
    PR-URL: #44258
    Refs: #44179
    Refs: #44252
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3765c63 View commit details
    Browse the repository at this point in the history
  154. doc: add TypeScript execution requirements

    Add section with high level approach/requirements for
    enabling TypeScript execution as discussed in the Next-10
    [TypeScript mini-summit](nodejs/next-10#150)
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #44030
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    mhdawson authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    7a56787 View commit details
    Browse the repository at this point in the history
  155. report: print javascript stack on fatal error

    Try to print JavaScript stack on fatal error. OOMError needs to be
    distinguished from fatal error since no new handle can be created at
    that time.
    
    PR-URL: #44242
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8cf6499 View commit details
    Browse the repository at this point in the history
  156. test: add coverage for invalid RSA-PSS digests

    PR-URL: #44271
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a2707d0 View commit details
    Browse the repository at this point in the history
  157. src: refactor to avoid using a moved object

    KeyPairGenTraits::EncodeKey should not use an object that it previously
    moved. Make ManagedEVPPKey::ToEncoded(Public|Private)Key non-static
    members of ManagedEVPPKey and call them on the key object instead.
    
    PR-URL: #44269
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    3dadc95 View commit details
    Browse the repository at this point in the history
  158. doc: fix typo

    PR-URL: #44262
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    h-a-n-a authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d3f3bf6 View commit details
    Browse the repository at this point in the history
  159. doc: fix optionality of callback arg of checkPrime

    The callback argument is required.
    
    PR-URL: #44311
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    tniessen authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    a933712 View commit details
    Browse the repository at this point in the history
  160. test_runner: fix test runner hooks failure stack

    PR-URL: #44284
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    MoLow authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c0b160c View commit details
    Browse the repository at this point in the history
  161. perf_hooks: add resourcetiming buffer limit

    Add WebPerf API `performance.setResourceTimingBufferSize` and event
    `'resourcetimingbufferfull'` support.
    
    The resource timing entries are added to the global performance
    timeline buffer automatically when using fetch. If users are not
    proactively cleaning these events, it can grow without limit. Apply
    the https://www.w3.org/TR/timing-entrytypes-registry/ default
    resource timing buffer max size so that the buffer can be limited
    to not grow indefinitely.
    
    PR-URL: #44220
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    legendecas authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    0e38fba View commit details
    Browse the repository at this point in the history
  162. meta: update AUTHORS

    PR-URL: #44321
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    8977a87 View commit details
    Browse the repository at this point in the history
  163. src: use imported namespaces in node_contextify.cc

    PR-URL: #44299
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    juanarbol authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    e9d19ac View commit details
    Browse the repository at this point in the history
  164. tools: update lint-md-dependencies to rollup@2.78.1

    PR-URL: #44320
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    f7c1b83 View commit details
    Browse the repository at this point in the history
  165. fs: add encoding parameter to benchmarks

    PR-URL: #44278
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    anonrig authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    4ec3f67 View commit details
    Browse the repository at this point in the history
  166. deps: update corepack to 0.13.0

    PR-URL: #44318
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    c270b9a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. lib: add diagnostics channel and perf hooks detail

    Co-Authored-By: theanarkh <theratliter@gmail.com>
    PR-URL: #43984
    Backport-PR-URL: #44256
    Reviewed-By: Matteo Collina matteo.collina@gmail.com
    Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
    Reviewed-By: Minwoo Jung nodecorelab@gmail.com
    2 people authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    1a44fbc View commit details
    Browse the repository at this point in the history
  2. test: deflake test-diagnostics-channel-net

    This test uses the deprecated methods in `diagnostic_channel` (see the
    reference), which are deprecated because the channels can be GC'd while
    in use, leading to lost messages.
    
    Change to use the non-deprecated APIs, which should work. I wasn't able
    to reproduce this locally; I assume it's memory dependent.
    
    Refs: #42714
    Fixes: #44143
    PR-URL: #44144
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    kvakil authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    514e516 View commit details
    Browse the repository at this point in the history
  3. net: create diagnostics channels lazily

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    1b3fcf7 View commit details
    Browse the repository at this point in the history
  4. bootstrap: implement --snapshot-blob and --build-snapshot

    This patch introduces `--build-snapshot` and `--snapshot-blob` options
    for creating and using user land snapshots.
    
    For the initial iteration, user land CJS modules and ESM are not yet
    supported in the snapshot, so only one single file can be snapshotted
    (users can bundle their applications into a single script with their
    bundler of choice to build a snapshot though).
    
    A subset of builtins should already work, and support for more builtins
    are being added. This PR includes tests checking that the TypeScript
    compiler and the marked markdown renderer (and the builtins they use)
    can be snapshotted and deserialized.
    
    To generate a snapshot using `snapshot.js` as entry point and write the
    snapshot blob to `snapshot.blob`:
    
    ```
    $ echo "globalThis.foo = 'I am from the snapshot'" > snapshot.js
    $ node --snapshot-blob snapshot.blob --build-snapshot snapshot.js
    ```
    
    To restore application state from `snapshot.blob`, with `index.js` as
    the entry point script for the deserialized application:
    
    ```
    $ echo "console.log(globalThis.foo)" > index.js
    $ node --snapshot-blob snapshot.blob index.js
    I am from the snapshot
    ```
    
    Users can also use the `v8.startupSnapshot` API to specify an entry
    point at snapshot building time, thus avoiding the need of an additional
    entry script at deserialization time:
    
    ```
    $ echo "require('v8').startupSnapshot.setDeserializeMainFunction(() => console.log('I am from the snapshot'))" > snapshot.js
    $ node --snapshot-blob snapshot.blob --build-snapshot snapshot.js
    $ node --snapshot-blob snapshot.blob
    I am from the snapshot
    ```
    
    Note that this patch only adds functionality to the `node` executable
    for building run-time user-land snapshots, the generated snapshot is
    stored into a separate file on disk. Building a single binary with both
    Node.js and an embedded snapshot has already been possible with the
    `--node-snapshot-main` option to the `configure` script if the user
    compiles Node.js from source. It would be a different task to enable the
    `node` executable to produce a single binary that contains both Node.js
    and an embedded snapshot without building Node.js from source, which
    should be layered on top of the SEA (Single Executable Apps) initiative.
    
    Known limitations/bugs that are being fixed in the upstream:
    
    - V8 hits a DCHECK when deserializing certain mutated globals, e.g.
      `Error.stackTraceLimit` (it should work fine in the release build,
      however): https://chromium-review.googlesource.com/c/v8/v8/+/3319481
    - Layout of V8's read-only heap can be inconsistent after
      deserialization, resulting in memory corruption:
      https://bugs.chromium.org/p/v8/issues/detail?id=12921
    
    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    3561514 View commit details
    Browse the repository at this point in the history
  5. bootstrap: clean up warning setup during serialization

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    597a517 View commit details
    Browse the repository at this point in the history
  6. test: add UMD module test with marked

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d4189ab View commit details
    Browse the repository at this point in the history
  7. test: test snapshotting TypeScript compiler

    PR-URL: #38905
    Refs: #35711
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    joyeecheung authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    40b817c View commit details
    Browse the repository at this point in the history
  8. bootstrap: fixup Error.stackTraceLimit for user-land snapshot

    It's difficult for V8 to handle Error.stackTraceLimit in the snapshot,
    so delete it from the Error constructor if it's present before
    snapshot serialization, and re-install it after deserialization.
    In addition try not to touch it from our internals during snapshot
    building in the first place by updating
    isErrorStackTraceLimitWritable().
    
    PR-URL: #44203
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    joyeecheung authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    87d7845 View commit details
    Browse the repository at this point in the history
  9. src: disambiguate terms used to refer to builtins and addons

    The term "native module" dates back to some of the oldest code
    in the code base. Within the context of Node.js core it usually
    refers to modules that are native to Node.js (e.g. fs, http),
    but it can cause confusion for people who don't work on this
    part of the code base, as "native module" can also refer to
    native addons - which is even the case in some of the API
    docs and error messages.
    
    This patch tries to make the usage of these terms more consistent.
    Now within the context of Node.js core:
    
    - JavaScript scripts that are built-in to Node.js are now referred
      to as "built-in(s)". If they are available as modules,
      they can also be referred to as "built-in module(s)".
    - Dynamically-linked shared objects that are loaded into
      the Node.js processes are referred to as "addons".
    
    We will try to avoid using the term "native modules" because it could
    be ambiguous.
    
    Changes in this patch:
    
    File names:
    - node_native_module.h -> node_builtins.h,
    - node_native_module.cc -> node_builtins.cc
    
    C++ binding names:
    - `native_module` -> `builtins`
    
    `node::Environment`:
    - `native_modules_without_cache` -> `builtins_without_cache`
    - `native_modules_with_cache` -> `builtins_with_cache`
    - `native_modules_in_snapshot` -> `builtins_in_cache`
    - `native_module_require` -> `builtin_module_require`
    
    `node::EnvSerializeInfo`:
    - `native_modules` -> `builtins
    
    `node::native_module::NativeModuleLoader`:
    - `native_module` namespace -> `builtins` namespace
    - `NativeModuleLoader` -> `BuiltinLoader`
    - `NativeModuleRecordMap` -> `BuiltinSourceMap`
    - `NativeModuleCacheMap` -> `BuiltinCodeCacheMap`
    - `ModuleIds` -> `BuiltinIds`
    - `ModuleCategories` -> `BuiltinCategories`
    - `LoadBuiltinModuleSource` -> `LoadBuiltinSource`
    
    `loader.js`:
    - `NativeModule` -> `BuiltinModule` (the `NativeModule` name used in
      `process.moduleLoadList` is kept for compatibility)
    
    And other clarifications in the documentation and comments.
    
    PR-URL: #44135
    Fixes: #44036
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    joyeecheung authored and ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    ab73cc8 View commit details
    Browse the repository at this point in the history
  10. 2022-08-24, Version 18.8.0 (Current)

    Notable changes:
    
    * bootstrap:
      * implement run-time user-land snapshots via --build-snapshot and
      --snapshot-blob (Joyee Cheung) in #38905
    * crypto:
      * (SEMVER-MINOR) allow zero-length IKM in HKDF and in webcrypto PBKDF2
      (Filip Skokan) #44201
      * (SEMVER-MINOR) allow zero-length secret KeyObject
      (Filip Skokan) #44201
    * deps:
      * upgrade npm to 8.18.0 (npm team) #44263 - Adds a new npm query cmd
    * doc:
      * add Erick Wendel to collaborators (Erick Wendel) #44088
      * add theanarkh to collaborators (theanarkh) #44131
      * add MoLow to collaborators (Moshe Atlow) #44214
      * add cola119 to collaborators (cola119) #44248
      * deprecate --trace-atomics-wait (Keyhan Vakil) #44093
    * http:
      * (SEMVER-MINOR) make idle http parser count configurable
      (theanarkh) #43974
    * net:
      * (SEMVER-MINOR) add local family (theanarkh) #43975
    * src:
      * (SEMVER-MINOR) print source map error source on demand
      (Chengzhong Wu) #43875
    * tls:
      * (SEMVER-MINOR) pass a valid socket on tlsClientError
      (Daeyeon Jeong) #44021
    
    PR-URL: #44353
    ruyadorno committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    c200106 View commit details
    Browse the repository at this point in the history