New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watch: add initial implementation for node --watch
#44366
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| 'use strict'; | ||
| const { | ||
| ArrayPrototypeFilter, | ||
| ArrayPrototypeForEach, | ||
| ArrayPrototypeJoin, | ||
| ArrayPrototypeMap, | ||
| ArrayPrototypePushApply, | ||
| ArrayPrototypeSlice, | ||
| } = primordials; | ||
|
|
||
| const { | ||
| prepareMainThreadExecution, | ||
| markBootstrapComplete | ||
| } = require('internal/process/pre_execution'); | ||
| const { triggerUncaughtException } = internalBinding('errors'); | ||
| const { getOptionValue } = require('internal/options'); | ||
| const { emitExperimentalWarning } = require('internal/util'); | ||
| const { FilesWatcher } = require('internal/watch_mode/files_watcher'); | ||
| const { green, blue, red, white, clear } = require('internal/util/colors'); | ||
|
|
||
| const { spawn } = require('child_process'); | ||
| const { inspect } = require('util'); | ||
| const { setTimeout, clearTimeout } = require('timers'); | ||
| const { resolve } = require('path'); | ||
| const { once, on } = require('events'); | ||
|
|
||
|
|
||
| prepareMainThreadExecution(false, false); | ||
| markBootstrapComplete(); | ||
|
|
||
| // TODO(MoLow): Make kill signal configurable | ||
| const kKillSignal = 'SIGTERM'; | ||
| const kShouldFilterModules = getOptionValue('--watch-path').length === 0; | ||
| const kWatchedPaths = ArrayPrototypeMap(getOptionValue('--watch-path'), (path) => resolve(path)); | ||
| const kCommand = ArrayPrototypeSlice(process.argv, 1); | ||
| const kCommandStr = inspect(ArrayPrototypeJoin(kCommand, ' ')); | ||
| const args = ArrayPrototypeFilter(process.execArgv, (arg, i, arr) => | ||
| arg !== '--watch-path' && arr[i - 1] !== '--watch-path' && arg !== '--watch'); | ||
| ArrayPrototypePushApply(args, kCommand); | ||
|
|
||
| const watcher = new FilesWatcher({ throttle: 500, mode: kShouldFilterModules ? 'filter' : 'all' }); | ||
| ArrayPrototypeForEach(kWatchedPaths, (p) => watcher.watchPath(p)); | ||
|
|
||
| let graceTimer; | ||
| let child; | ||
| let exited; | ||
|
|
||
| function start() { | ||
| exited = false; | ||
| const stdio = kShouldFilterModules ? ['inherit', 'inherit', 'inherit', 'ipc'] : undefined; | ||
| child = spawn(process.execPath, args, { stdio, env: { ...process.env, WATCH_REPORT_DEPENDENCIES: '1' } }); | ||
| watcher.watchChildProcessModules(child); | ||
| child.once('exit', (code) => { | ||
| exited = true; | ||
| if (code === 0) { | ||
| process.stdout.write(`${blue}Completed running ${kCommandStr}${white}\n`); | ||
| } else { | ||
| process.stdout.write(`${red}Failed running ${kCommandStr}${white}\n`); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| async function killAndWait(signal = kKillSignal, force = false) { | ||
| child?.removeAllListeners(); | ||
| if (!child) { | ||
| return; | ||
| } | ||
| if ((child.killed || exited) && !force) { | ||
| return; | ||
| } | ||
| const onExit = once(child, 'exit'); | ||
| child.kill(signal); | ||
| const { 0: exitCode } = await onExit; | ||
| return exitCode; | ||
| } | ||
|
|
||
| function reportGracefulTermination() { | ||
| // Log if process takes more than 500ms to stop. | ||
| let reported = false; | ||
| clearTimeout(graceTimer); | ||
| graceTimer = setTimeout(() => { | ||
| reported = true; | ||
| process.stdout.write(`${blue}Waiting for graceful termination...${white}\n`); | ||
| }, 500).unref(); | ||
| return () => { | ||
| clearTimeout(graceTimer); | ||
| if (reported) { | ||
| process.stdout.write(`${clear}${green}Gracefully restarted ${kCommandStr}${white}\n`); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| async function stop() { | ||
| watcher.clearFileFilters(); | ||
| const clearGraceReport = reportGracefulTermination(); | ||
| await killAndWait(); | ||
| clearGraceReport(); | ||
| } | ||
|
|
||
| async function restart() { | ||
| process.stdout.write(`${clear}${green}Restarting ${kCommandStr}${white}\n`); | ||
| await stop(); | ||
| start(); | ||
| } | ||
|
|
||
| (async () => { | ||
| emitExperimentalWarning('Watch mode'); | ||
|
|
||
| try { | ||
| start(); | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| for await (const _ of on(watcher, 'changed')) { | ||
| await restart(); | ||
| } | ||
| } catch (error) { | ||
| triggerUncaughtException(error, true /* fromPromise */); | ||
| } | ||
| })(); | ||
|
|
||
| // Exiting gracefully to avoid stdout/stderr getting written after | ||
| // parent process is killed. | ||
| // this is fairly safe since user code cannot run in this process | ||
| function signalHandler(signal) { | ||
| return async () => { | ||
| watcher.clear(); | ||
| const exitCode = await killAndWait(signal, true); | ||
| process.exit(exitCode ?? 0); | ||
| }; | ||
| } | ||
| process.on('SIGTERM', signalHandler('SIGTERM')); | ||
| process.on('SIGINT', signalHandler('SIGINT')); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| blue: '', | ||
| green: '', | ||
| white: '', | ||
| red: '', | ||
| clear: '', | ||
| hasColors: false, | ||
| refresh() { | ||
| if (process.stderr.isTTY) { | ||
| const hasColors = process.stderr.hasColors(); | ||
| module.exports.blue = hasColors ? '\u001b[34m' : ''; | ||
| module.exports.green = hasColors ? '\u001b[32m' : ''; | ||
| module.exports.white = hasColors ? '\u001b[39m' : ''; | ||
| module.exports.red = hasColors ? '\u001b[31m' : ''; | ||
| module.exports.clear = hasColors ? '\u001bc' : ''; | ||
| module.exports.hasColors = hasColors; | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| module.exports.refresh(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "clear" should be at least configurable, as the
--preserveWatchOutputoption withtsc