Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: codify findSourceMap return value when not found #44397

Merged
merged 1 commit into from
Aug 27, 2022
Merged

lib: codify findSourceMap return value when not found #44397

merged 1 commit into from
Aug 27, 2022

Conversation

legendecas
Copy link
Member

Return undefined when no source map is found for the given filename on
findSourceMap.

Fixes: #44391

@legendecas
lib: codify findSourceMap return value when not found
b0dbfd1 
Return `undefined` when no source map is found for the given filename on
`findSourceMap`.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 25, 2022
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46254/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit 72df448 into nodejs:main Aug 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 72df448

@legendecas legendecas deleted the issue-44391 branch August 28, 2022 06:45
RafaelGSS pushed a commit that referenced this pull request Sep 5, 2022
@legendecas @RafaelGSS
lib: codify findSourceMap return value when not found
b8f08e5 
Return `undefined` when no source map is found for the given filename on
`findSourceMap`.

PR-URL: #44397
Fixes: #44391
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 5, 2022
Merged
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@legendecas @Fyko
lib: codify findSourceMap return value when not found
a4fc4d9 
Return `undefined` when no source map is found for the given filename on
`findSourceMap`.

PR-URL: nodejs#44397
Fixes: nodejs#44391
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol
Copy link
Member

Depends on #43875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node.js 18.8.0 changed return type of module.findSourceMap()
5 participants
@legendecas @nodejs-github-bot @juanarbol @lpinca @aduh95