Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: backport ff8d67c88449 #44423

Merged
merged 1 commit into from Sep 1, 2022
Merged

Commits on Aug 28, 2022

  1. deps: V8: backport ff8d67c88449

    Original commit message:
    
        Reland "Fix Context PromiseHook behaviour with debugger enabled"
    
        This is a reland of commit 872b7faa32d837f9b166d750328357f856168e72
    
        Original change's description:
        > Fix Context PromiseHook behaviour with debugger enabled
        >
        > This is a solution for nodejs#43148.
        >
        > Due to differences in behaviour between code with and without the debugger enabled, some promise lifecycle events were being missed and some extra ones were being added. This change resolves this and verifies the event sequence is consistent between code with and without the debugger.
        >
        > Change-Id: I3dabf1dceb14233226b1752083d659f1c2f97966
        > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779922
        > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
        > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        > Cr-Commit-Position: refs/heads/main@{#82132}
    
        Change-Id: Ifdd407261c793887fbd012d5a04ba36b3744c349
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3805979
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Clemens Backes <clemensb@chromium.org>
        Commit-Queue: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Victor Gomes <victorgomes@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#82575}
    
    Refs: v8/v8@ff8d67c
    Fixes: nodejs#43148
    Fixes: nodejs#44415
    targos committed Aug 28, 2022
    Copy the full SHA
    72b15c9 View commit details
    Browse the repository at this point in the history