Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,test: improvements and cleanup for assert.snapshot() #44429

Merged
merged 3 commits into from Sep 1, 2022
Merged

doc,test: improvements and cleanup for assert.snapshot() #44429

merged 3 commits into from Sep 1, 2022

Commits on Sep 1, 2022

  1. doc: improve assert.snapshot() docs 

    PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @cjihrig
    cjihrig committed Sep 1, 2022
    Copy the full SHA
    39998c9 View commit details
    Browse the repository at this point in the history

  2. test: style updates for assert.snapshot() 

    This commit updates the assert.snapshot() fixtures to better
match the code style of the rest of the codebase.

PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @cjihrig
    cjihrig committed Sep 1, 2022
    Copy the full SHA
    1fe4e55 View commit details
    Browse the repository at this point in the history

  3. doc: add --update-assert-snapshot to node.1 

    PR-URL: nodejs#44429
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    @cjihrig
    cjihrig committed Sep 1, 2022
    Copy the full SHA
    cf7539a View commit details
    Browse the repository at this point in the history