Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix duration_ms to be milliseconds #44490

Merged
merged 1 commit into from Mar 31, 2023
Merged

tools: fix duration_ms to be milliseconds #44490

merged 1 commit into from Mar 31, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 2, 2022 •
edited by cclauss

I figured if we land #44450 (merged) it will be best to also fix it here.
this fix depends on nodejs/tap2junit#38 (merged)

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Sep 2, 2022
@mscdex mscdex changed the title fix duration_ms to be milliseconds tools: fix duration_ms to be milliseconds Sep 2, 2022
@MoLow MoLow added the review wanted PRs that need reviews. label Sep 4, 2022
@MoLow
Copy link
Member Author

MoLow commented Sep 5, 2022

@cclauss can you take a look at this and at nodejs/tap2junit#38 ?

@MoLow MoLow requested a review from aduh95 September 5, 2022 14:56
aduh95
aduh95 reviewed Sep 6, 2022
View reviewed changes
tools/test.py Show resolved Hide resolved
@targos targos added blocked PRs that are blocked by other issues or PRs. lts-watch-v14.x labels Sep 6, 2022
@MoLow MoLow removed the review wanted PRs that need reviews. label Sep 11, 2022
@juanarbol juanarbol removed the blocked PRs that are blocked by other issues or PRs. label Oct 27, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47510/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 27, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47513/

@MoLow
Copy link
Member Author

MoLow commented Oct 28, 2022

@juanarbol AFAIK this is still blocked due to nodejs/tap2junit#41

@MoLow MoLow added the blocked PRs that are blocked by other issues or PRs. label Oct 28, 2022
This was referenced Oct 29, 2022
Open
Open
Open
Open
@MoLow MoLow removed the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50715/

@github-actions github-actions bot mentioned this pull request Mar 31, 2023
Open
34 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50726/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit b541d2c into nodejs:main Mar 31, 2023
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b541d2c

@MoLow MoLow deleted the fix-duration-ms branch March 31, 2023 12:25
This was referenced Apr 1, 2023
Open
Open
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
e574827 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
15e68fa 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
8ad53a1 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@MoLow @RafaelGSS
tools: fix duration_ms to be milliseconds
03b6650 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@MoLow @danielleadams
tools: fix duration_ms to be milliseconds
6ab2215 
PR-URL: #44490
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
@richardlau richardlau mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@cclauss cclauss cclauss approved these changes

@aduh95 aduh95 aduh95 approved these changes

@juanarbol juanarbol juanarbol approved these changes

@cjihrig cjihrig Awaiting requested review from cjihrig

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MoLow @nodejs-github-bot @jasnell @benjamingr @cclauss @himself65 @aduh95 @juanarbol @targos