test: use 2048 bit RSA keys

[mmomtchev]

OpenSSL now requires at least 2048
Refs: #44497

[lpinca]

Are you planning to update certs and keys in a follow-up PR?

[mmomtchev]

@lpinca Just realized that these were comitted too, done

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46399/

[mmomtchev]

@lpinca This turned to be much more laborious that I previously thought so I scaled it back to simply replacing all 1024 bit keys with 2048 bit keys, I am leaving the 2048->4096 transition to the next unlucky soul because there is a list of hard-coded test vectors produced with another crypto system meant for testing compatibility.

There is also the DH512 keys which have been blocked (?) because of the logjam attack, I will do them separately

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46427/

[mmomtchev]

node-test-commit-linuxone-rhel8-s390x is an abort on an out of memory condition - is this a flaky test?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46641/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46860/

[mmomtchev]

No space left on the disk in Jenkins

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46864/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/44498
✔  Done loading data for nodejs/node/pull/44498
----------------------------------- PR info ------------------------------------
Title      test: use 2048 bit RSA keys (#44498)
Author     Momtchil Momtchev  (@mmomtchev)
Branch     mmomtchev:rsa-key-length -> nodejs:main
Labels     crypto, test, needs-ci, review wanted, commit-queue-squash
Commits    6
 - test: upgrade all 1024 bit RSA keys to 2048 bits
 - add missed fingerprints
 - renew ca1 with a 2048 bit key
 - run the linter
 - deprecate 1024 bit rsa keys for benchmarking
 - change all default keylengths to 2048
Committers 1
 - Momtchil Momtchev 
PR-URL: https://github.com/nodejs/node/pull/44498
Refs: https://github.com/nodejs/node/issues/44497
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44498
Refs: https://github.com/nodejs/node/issues/44497
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: upgrade all 1024 bit RSA keys to 2048 bits
   ⚠  - add missed fingerprints
   ⚠  - renew ca1 with a 2048 bit key
   ⚠  - run the linter
   ⚠  - deprecate 1024 bit rsa keys for benchmarking
   ⚠  - change all default keylengths to 2048
   ℹ  This PR was created on Fri, 02 Sep 2022 19:35:00 GMT
   ✔  Approvals: 2
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44498#pullrequestreview-1095481223
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/44498#pullrequestreview-1119033840
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-09-27T15:51:00Z: https://ci.nodejs.org/job/node-test-pull-request/46864/
- Querying data for job/node-test-pull-request/46864/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3137549599

[lpinca]

Landed in 8671e4a.

[juanarbol]

This is not landing clean in the v16.x branch; marking as "dont-land-on-v16.x"

=== release test-crypto-x509 ===
Path: parallel/test-crypto-x509
node:assert:124
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

+ 'C=US\nST=CA\nL=SF\nO=Joyent\nOU=Node.js\nCN=agent1\nemailAddress=ry@tinyclouds.org'
- [Object: null prototype] {
-   C: 'US',
-   CN: 'agent1',
-   L: 'SF',
-   O: 'Joyent',
-   OU: 'Node.js',
-   ST: 'CA',
-   emailAddress: 'ry@tinyclouds.org'
- }
    at Object.<anonymous> (/home/juanarbol/GitHub/node/test/parallel/test-crypto-x509.js:249:10)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'C=US\n' +
    'ST=CA\n' +
    'L=SF\n' +
    'O=Joyent\n' +
    'OU=Node.js\n' +
    'CN=agent1\n' +
    'emailAddress=ry@tinyclouds.org',
  expected: [Object: null prototype] {
    C: 'US',
    ST: 'CA',
    L: 'SF',
    O: 'Joyent',
    OU: 'Node.js',
    CN: 'agent1',
    emailAddress: 'ry@tinyclouds.org'
  },
  operator: 'strictEqual'
}
Command: out/Release/node --expose-internals /home/juanarbol/GitHub/node/test/parallel/test-crypto-x509.js