New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-performance-measure #44637

Closed

smitley wants to merge 1 commit into nodejs:main from smitley:fixperftest

Commits on Sep 14, 2022

test: fix test-performance-measure

Refs: nodejs#42949

Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args)
there is no guarantee that setTimeout won't complete early.

From the failure of nodejs#42949 this
is likely what happened.

I have updated the assert.ok test to allow some variation in
the test.

smitley committed Sep 14, 2022