Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: add unique events benchmark #44657

Merged
merged 1 commit into from Oct 14, 2022
Merged

events: add unique events benchmark #44657

merged 1 commit into from Oct 14, 2022

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 15, 2022

Following up on #44627 (comment), adding benchmark written by @mscdex

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. labels Sep 15, 2022
aduh95
aduh95 approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider adding in the commit message:

Co-authored-by: Brian White <mscdex@mscdex.net>

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@anonrig @mscdex
events: add unique events benchmark
267a03e 
Co-authored-by: Brian White <mscdex@mscdex.net>
PR-URL: nodejs#44657
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@anonrig anonrig merged commit 267a03e into nodejs:main Oct 14, 2022
@anonrig anonrig deleted the benchmark/events branch October 14, 2022 15:44
@anonrig
Copy link
Member Author

anonrig commented Oct 14, 2022

Landed in 267a03e

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@anonrig @mscdex @RafaelGSS
events: add unique events benchmark
e858b3c 
Co-authored-by: Brian White <mscdex@mscdex.net>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@anonrig @mscdex @RafaelGSS
events: add unique events benchmark
c3dd696 
Co-authored-by: Brian White <mscdex@mscdex.net>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @mscdex @danielleadams
events: add unique events benchmark
48fc8d5 
Co-authored-by: Brian White <mscdex@mscdex.net>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @mscdex @danielleadams
events: add unique events benchmark
78226b2 
Co-authored-by: Brian White <mscdex@mscdex.net>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig @mscdex @danielleadams
events: add unique events benchmark
3bb764a 
Co-authored-by: Brian White <mscdex@mscdex.net>
PR-URL: #44657
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@JungMinu JungMinu JungMinu approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@anonrig @lpinca @JungMinu @aduh95 @mcollina @nodejs-github-bot