Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: don't match sourceMappingURL in strings #44658

Closed
wants to merge 3 commits into from
Closed

lib: don't match sourceMappingURL in strings #44658

wants to merge 3 commits into from

Commits on Sep 16, 2022

  1. lib: don't match sourceMappingURL in strings 

    Prior to this change `sourceMappingURL` in string where being matched
by the RegExp which caused sourcemaps not be loaded when using the
`--enable-source-maps` flag. This commit changes the RegExp to match
the last occurrence.

Fixes: nodejs#44654
    @alan-agius4
    alan-agius4 committed Sep 16, 2022
    Copy the full SHA
    680947c View commit details
    Browse the repository at this point in the history

  2. fixup! lib: don't match sourceMappingURL in strings

    @alan-agius4
    alan-agius4 committed Sep 16, 2022
    Copy the full SHA
    3b104a4 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. fixup! lib: don't match sourceMappingURL in strings 

    Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
    @alan-agius4 @legendecas
    alan-agius4 and legendecas committed Sep 18, 2022
    Copy the full SHA
    3bf0e8d View commit details
    Browse the repository at this point in the history