Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: ensure to revert node_version changes #44760

Closed
wants to merge 1 commit into from
Closed

doc: ensure to revert node_version changes #44760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions doc/contributing/releases.md
View file
Open in desktop
Expand Up @@ -705,13 +705,17 @@ $ git pull upstream main
$ git cherry-pick v1.x^
```

Git should stop to let you fix conflicts. Revert all changes that were made to
`src/node_version.h`:
Git should stop to let you fix conflicts.

Revert all changes that were made to `src/node_version.h`:

```console
$ git checkout --ours HEAD -- src/node_version.h
```

Even if there are no conflicts, ensure that you revert all the changes that were
made to `src/node_version.h`.

If there are conflicts in `doc` due to updated `REPLACEME`
placeholders (that happens when a change previously landed on another release
branch), keep both version numbers. Convert the YAML field to an array if it is
Expand Down