Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: don't hard code name in validatePosition() #44767

Merged
merged 1 commit into from Sep 29, 2022
Merged

fs: don't hard code name in validatePosition() #44767

merged 1 commit into from Sep 29, 2022

Commits on Sep 29, 2022

  1. fs: don't hard code name in validatePosition() 

    The name of the position being validated by validatePosition()
was not being used. Instead, the string 'position' was being
used everywhere. It worked out because the only call sites were
using the name 'position' as well.

PR-URL: nodejs#44767
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    @cjihrig
    cjihrig committed Sep 29, 2022
    Copy the full SHA
    1b97188 View commit details
    Browse the repository at this point in the history