Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs(read(fd[, options], callback)): throw ERR_INVALID_ARG_TYPE when options.buffer is null #44769

Merged
merged 3 commits into from Sep 28, 2022
Merged

fs(read(fd[, options], callback)): throw ERR_INVALID_ARG_TYPE when options.buffer is null #44769

merged 3 commits into from Sep 28, 2022

Commits on Sep 25, 2022

  1. fs: add validateBuffer to improve error

    wafuwafu13 committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    b1b8d3f View commit details
    Browse the repository at this point in the history

  2. test: not validate the message, but rather the error code

    wafuwafu13 committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    9c62ea8 View commit details
    Browse the repository at this point in the history

  3. fix: use optional chaining instead of validateBuffer

    wafuwafu13 committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    888beff View commit details
    Browse the repository at this point in the history