Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove ParseIP() in cares_wrap.cc #44771

Merged
merged 1 commit into from Sep 29, 2022
Merged

src: remove ParseIP() in cares_wrap.cc #44771

merged 1 commit into from Sep 29, 2022

Commits on Sep 25, 2022

  1. src: remove ParseIP() in cares_wrap.cc 

    This function is only used in one place where the result argument is
never nullptr, so remove special handling of that case. Also, instead
of returning magic values 0/4/6 and then later translating those into
error/AF_INET/AF_INET6, use AF_INET/AF_INET6 directly. Lastly, inline
the function, which is simpler overall.
    @tniessen
    tniessen committed Sep 25, 2022
    Copy the full SHA
    ab683fd View commit details
    Browse the repository at this point in the history