tools: fix typo in tools/update-authors.mjs
#44780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Sep 25, 2022
MoLow
approved these changes
Sep 25, 2022
daeyeon
approved these changes
Sep 25, 2022
RaisinTen
added
the
author ready
|
There's a typo in the commit message. "ends" should end with an s 😄 |
RaisinTen
force-pushed
the
tools/fix-typo-in-tools/update-authors.mjs
branch
from
7a02a9d
to
f0689ac
Compare
|
@targos haha, thanks for catching, fixed! |
watilde
approved these changes
Sep 25, 2022
Trott
approved these changes
Sep 25, 2022
cjihrig
approved these changes
Sep 25, 2022
marsonya
approved these changes
Sep 26, 2022
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44780 ✔ Done loading data for nodejs/node/pull/44780 ----------------------------------- PR info ------------------------------------ Title tools: fix typo in `tools/update-authors.mjs` (#44780) Author Darshan Sen (@RaisinTen) Branch RaisinTen:tools/fix-typo-in-tools/update-authors.mjs -> nodejs:main Labels tools, author ready Commits 1 - tools: fix typo in tools/update-authors.mjs Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/44780 Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow Reviewed-By: Daeyeon Jeong Reviewed-By: Daijiro Wachi Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Akhil Marsonya ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44780 Reviewed-By: Luigi Pinca Reviewed-By: Moshe Atlow Reviewed-By: Daeyeon Jeong Reviewed-By: Daijiro Wachi Reviewed-By: Rich Trott Reviewed-By: Colin Ihrig Reviewed-By: Akhil Marsonya -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 25 Sep 2022 05:10:57 GMT ✔ Approvals: 7 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119372607 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119372708 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119373811 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119396414 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119432546 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119432783 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/44780#pullrequestreview-1119842989 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3137317680 |
The filename ends with an s. Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
force-pushed
the
tools/fix-typo-in-tools/update-authors.mjs
branch
from
f0689ac
to
4bb34aa
Compare
|
Yusss, CI is finally green! Can some please re-approve so that I can land this with the commit-queue label? Thanks! |
MoLow
approved these changes
Sep 29, 2022
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2a4452a |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
The filename ends with an s. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #44780 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filename ends with an s.
Signed-off-by: Darshan Sen raisinten@gmail.com