Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix operation not permitted #44786

Closed
wants to merge 3 commits into from
Closed

fs: fix operation not permitted #44786

wants to merge 3 commits into from

Commits on Sep 25, 2022

  1. fs: fix operation not permitted 

    fix: nodejs#44720

issue:
- `copyDir()` calls `checkPathsSync()`, which invokes `lstat()`
which causes error because of not checking the opts.filter

changes:
- check opts.filter before calling `checkPathsSync` and copy logic
- cleanup `startCopy` function
    @thoqbk
    thoqbk committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    980e96a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. fs: add test for cpSync

    @thoqbk
    thoqbk committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    ec30bf0 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. fs: update comment in tests for copy 

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    @thoqbk @joyeecheung
    thoqbk and joyeecheung committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9382365 View commit details
    Browse the repository at this point in the history