Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: initialize TextDecoder once for performance #44787

Merged
merged 1 commit into from Oct 10, 2022
+3 −1
Merged

buffer: initialize TextDecoder once for performance #44787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/internal/blob.js
View file
Open in desktop
Expand Up @@ -78,6 +78,7 @@ let ReadableStream;
let URL;

const enc = new TextEncoder();
let dec;
trivikr marked this conversation as resolved.
Show resolved Hide resolved

// Yes, lazy loading is annoying but because of circular
// references between the url, internal/blob, and buffer
Expand Down Expand Up @@ -311,7 +312,8 @@ class Blob {
if (!isBlob(this))
throw new ERR_INVALID_THIS('Blob');

const dec = new TextDecoder();
dec ??= new TextDecoder();

return dec.decode(await this.arrayBuffer());
}

Expand Down