Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use CHECK instead of EXPECT where necessary #44795

Closed
wants to merge 1 commit into from
Closed

test: use CHECK instead of EXPECT where necessary #44795

wants to merge 1 commit into from

Commits on Sep 26, 2022

  1. test: use CHECK instead of EXPECT where necessary 

    GetPageSize() and OverrunGuardedBuffer currently use non-fatal EXPECT_*
macros because GoogleTest does not allow the fatal variants ASSERT_* in
non-void returning functions (i.e., in this file, nowhere outside of the
TEST itself).

The EXPECT_* macros continue execution upon failure, but we really don't
want that (and static analysis apparently does not like it either).
Since we cannot use GoogleTest's ASSERT_* here, use our own CHECK_*
instead of EXPECT_* outside of the TEST. Hopefully, this will finally
pacify static analysis.

Refs: nodejs#44666
    @tniessen
    tniessen committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    21df9e2 View commit details
    Browse the repository at this point in the history