Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: make ContextifyContext a BaseObject #44796

Closed
wants to merge 5 commits into from

Commits on Sep 28, 2022

  1. src: refactor BaseObject methods

    - Wrap the initialization of the kSlot and kEmbedderType fields
      into a BaseObject::SetInternalFields() method.
    - Move the tagging of kEmbedderType field into
      BaseObject::TagNodeObject()
    - Add a variant of BaseObject::MakeLazilyInitializedJSTemplate()
      that only needs IsolateData.
    This makes it easier to create BaseObject subclasses.
    joyeecheung committed Sep 28, 2022
    Copy the full SHA
    b8f371e View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    6769aff View commit details
    Browse the repository at this point in the history
  3. vm: make ContextifyContext a BaseObject

    Instead of adding a reference to the ContextifyContext by using
    a v8::External, we make ContextifyContext a weak BaseObject that
    whose wrapper is referenced by the sandbox via a private symbol.
    This makes it easier to snapshot the contexts, in addition to
    reusing the BaseObject lifetime management for ContextifyContexts.
    joyeecheung committed Sep 28, 2022
    Copy the full SHA
    2a7de3e View commit details
    Browse the repository at this point in the history
  4. fixup! vm: make ContextifyContext a BaseObject

    This reverts commit b9042c87b60184a37d9c8674ec8c8b29b2a8ab5e.
    joyeecheung committed Sep 28, 2022
    Copy the full SHA
    cd6ffe3 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Copy the full SHA
    7f3cece View commit details
    Browse the repository at this point in the history