Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test_runner: support using --inspect with --test #44813

Closed
wants to merge 3 commits into from
Closed

[v18.x backport] test_runner: support using --inspect with --test #44813

wants to merge 3 commits into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 29, 2022 •
edited

this backport PR includes
#44520
#44592
#44620

to be merged after / on top of #44815

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 29, 2022
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
@MoLow
test_runner: support using --inspect with --test
4e3c2ca 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from 1cffc6c to 9fbebd2 Compare September 29, 2022 08:54
@MoLow
Copy link
Member Author

MoLow commented Sep 29, 2022

CC @nodejs/releasers

MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
@MoLow
test_runner: support using --inspect with --test
6b59510 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
@MoLow
cluster: use inspector utils
22121fe 
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
@MoLow
test: fix test-runner-inspect
c743751 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from 9fbebd2 to c743751 Compare September 29, 2022 09:04
@MoLow MoLow changed the title [v18.x backport] test_runner: support using --inspect with --test [v18.x backport] test_runner: support using --inspect with --test Sep 29, 2022
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
@MoLow
test_runner: support using --inspect with --test
7f2f502 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
@MoLow
cluster: use inspector utils
d6fc844 
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Sep 29, 2022
@MoLow
test: fix test-runner-inspect
37d1e5a 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from c743751 to 37d1e5a Compare September 29, 2022 13:58
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Sep 30, 2022
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46950/

This was referenced Oct 1, 2022
Open
Open
@MoLow
test_runner: support using --inspect with --test
faa8f8a 
PR-URL: nodejs#44520
Backport-PR-URL: nodejs#44813
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow
cluster: use inspector utils
b48c9a5 
PR-URL: nodejs#44592
Backport-PR-URL: nodejs#44813
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow
test: fix test-runner-inspect
a797681 
PR-URL: nodejs#44620
Backport-PR-URL: nodejs#44813
Fixes: nodejs#44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow force-pushed the backport-test-runner-inspect branch from 37d1e5a to a797681 Compare October 2, 2022 10:50
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46994/

@github-actions github-actions bot mentioned this pull request Oct 3, 2022
Open
9 tasks
@MoLow
Copy link
Member Author

MoLow commented Oct 3, 2022

CC @danielleadams

@MoLow MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 3, 2022
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
@MoLow @danielleadams
test_runner: support using --inspect with --test
3c1e9d4 
PR-URL: #44520
Backport-PR-URL: #44813
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
@MoLow @danielleadams
cluster: use inspector utils
7fb9cc7 
PR-URL: #44592
Backport-PR-URL: #44813
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 4, 2022
@MoLow @danielleadams
test: fix test-runner-inspect
56c9c98 
PR-URL: #44620
Backport-PR-URL: #44813
Fixes: #44600
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams
Copy link
Member

Landed in 36227ed...56c9c98

@github-actions github-actions bot mentioned this pull request Oct 5, 2022
Open
19 tasks
@MoLow MoLow deleted the backport-test-runner-inspect branch October 12, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MoLow @nodejs-github-bot @danielleadams @RafaelGSS