src: use OnScopeLeave instead of multiple free() #44852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not great either but it avoids having to call OPENSSL_free() in more than one branch, thus reducing the risk of memory leaks.
tniessen
added
tls
|
Review requested:
|
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Oct 1, 2022
@cjihrig Agreed, but the new-ish |
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
daeyeon
approved these changes
Oct 2, 2022
github-actions
bot
removed
the
request-ci
RaisinTen
approved these changes
Oct 2, 2022
jasnell
approved these changes
Oct 2, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b5e1387 |
TimShilov
pushed a commit
to TimShilov/node
that referenced
this pull request
Oct 3, 2022
This is not great either but it avoids having to call OPENSSL_free() in more than one branch, thus reducing the risk of memory leaks. PR-URL: nodejs#44852 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
16 tasks
panva
pushed a commit
to panva/node
that referenced
this pull request
Oct 4, 2022
This is not great either but it avoids having to call OPENSSL_free() in more than one branch, thus reducing the risk of memory leaks. PR-URL: nodejs#44852 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
19 tasks
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
This is not great either but it avoids having to call OPENSSL_free() in more than one branch, thus reducing the risk of memory leaks. PR-URL: #44852 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not perfect either but it avoids having to call
OPENSSL_free()in more than one branch, thus reducing the risk of memory leaks.