Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: promise version of streams.finished call cleanup after eos #44862

Merged
merged 4 commits into from Oct 15, 2022
Merged

lib: promise version of streams.finished call cleanup after eos #44862

merged 4 commits into from Oct 15, 2022

Commits on Oct 2, 2022

  1. lib: promise version of streams.finished call clean up 

    implement autoCleanup logic. update docs add autoCleanup description

ref: nodejs#44556
    @ntedgi
    ntedgi committed Oct 2, 2022
    Copy the full SHA
    9b778f1 View commit details
    Browse the repository at this point in the history

  2. test: adding unit tests to cover the autoCleanup parameter logic 

    doc: update autoCleanup default value to false
    @ntedgi
    ntedgi committed Oct 2, 2022
    Copy the full SHA
    cd80cdc View commit details
    Browse the repository at this point in the history

  3. fix linting issues

    @ntedgi
    ntedgi committed Oct 2, 2022
    Copy the full SHA
    b65461a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. rename parameter from autoCleanup to cleanup

    @ntedgi
    ntedgi committed Oct 10, 2022
    Copy the full SHA
    16d45f1 View commit details
    Browse the repository at this point in the history