Commits on Oct 3, 2022

1. tools: fix timezone update tool …

   The spawnSync call was previously silently failing with this error:
   ```sh
   icupkg: unable to open input file "icudt*.dat"
   ```
   because spawnSync doesn't support globbing. This change replaces the
   spawnSync call with execSync because that supports globbing.
   
   I have tested this workflow with some minor modifications in my fork and
   I can confirm that it works as expected now. The bot opened this PR -
   #2 which updates
   deps/icu-small/source/data/in/icudt71l.dat.bz2.
   
   Fixes: nodejs#44865
   Signed-off-by: Darshan Sen <raisinten@gmail.com>

   

   RaisinTen committed Oct 3, 2022
   Copy the full SHA

   0210498 View commit details

   Browse the repository at this point in the history

2. tools: remove faulty early termination logic from update-timezone.mjs …

   We do not build Node.js in the workflow so
   https://github.com/nodejs/node/blob/f4815fcd7691364d8139b44c1295dbc46f6ee4a8/tools/update-timezone.mjs#L18
   is actually the version of `tzdata` in the Node.js in the runner instead
   of what's in `main`.
   
   The script is pretty fast even when the versions differ and there is an
   update, so this optimization doesn't seem to be worth having given the
   problem.
   
   Signed-off-by: Darshan Sen <raisinten@gmail.com>

   

   RaisinTen committed Oct 3, 2022
   Copy the full SHA

   33d4ff6 View commit details

   Browse the repository at this point in the history