Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: optimize ALPN callback #44875

Closed
wants to merge 2 commits into from
Closed

src: optimize ALPN callback #44875

wants to merge 2 commits into from

Commits on Oct 3, 2022

  1. src: simplify ALPN code, remove indirection

    @bnoordhuis
    bnoordhuis committed Oct 3, 2022
    Copy the full SHA
    432ca36 View commit details
    Browse the repository at this point in the history

  2. src: optimize ALPN callback 

    It doesn't make sense from a performance perspective to retain an
arraybuffer with the ALPN byte string and look it up as a property on
the JS context object for every TLS handshake.

Store the byte string in the C++ TLSWrap object instead. That's both
a lot faster and a lot simpler.
    @bnoordhuis
    bnoordhuis committed Oct 3, 2022
    Copy the full SHA
    0f58967 View commit details
    Browse the repository at this point in the history