Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: require JSDoc in internal validators code #44896

Merged
merged 1 commit into from Oct 7, 2022
Merged

lib: require JSDoc in internal validators code #44896

merged 1 commit into from Oct 7, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 5, 2022

Closes: #44893

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 5, 2022
@Trott Trott mentioned this pull request Oct 5, 2022
Closed
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47077/

anonrig
anonrig reviewed Oct 5, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 5, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47109/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/44896
✔  Done loading data for nodejs/node/pull/44896
----------------------------------- PR info ------------------------------------
Title      lib: require JSDoc in internal validators code (#44896)
Author     Rich Trott  (@Trott)
Branch     Trott:validator -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - lib: require JSDoc in internal validators code
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44896
Fixes: https://github.com/nodejs/node/issues/44893
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44896
Fixes: https://github.com/nodejs/node/issues/44893
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - lib: require JSDoc in internal validators code
   ℹ  This PR was created on Wed, 05 Oct 2022 03:09:30 GMT
   ✔  Approvals: 2
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/44896#pullrequestreview-1132028270
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44896#pullrequestreview-1133531828
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-06T21:27:58Z: https://ci.nodejs.org/job/node-test-pull-request/47109/
- Querying data for job/node-test-pull-request/47109/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3205068185

@Trott
lib: require JSDoc in internal validators code
c50987e 
Closes: nodejs#44893
PR-URL: nodejs#44896
Fixes: nodejs#44893
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott merged commit c50987e into nodejs:main Oct 7, 2022
@Trott
Copy link
Member Author

Trott commented Oct 7, 2022

Landed in c50987e

@Trott Trott deleted the validator branch October 7, 2022 13:29
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@Trott @danielleadams
lib: require JSDoc in internal validators code
ada7d82 
Closes: #44893
PR-URL: #44896
Fixes: #44893
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@lpinca lpinca lpinca approved these changes

@himself65 himself65 himself65 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require JsDoc on validators
5 participants
@Trott @nodejs-github-bot @lpinca @anonrig @himself65