Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: return void in InitializeInspector() #44903

Merged
merged 1 commit into from Oct 14, 2022
Merged

src: return void in InitializeInspector() #44903

merged 1 commit into from Oct 14, 2022

Commits on Oct 6, 2022

  1. src: return void in InitializeInspector() 

    We have been ignoring inspector port binding errors during startup.
Handling this error would be a breaking change and it's probably
surprising to refuse to launch the Node.js instance simply because
the inspector cannot listen to the port anyway. So just turn the
return value of InitializeInspector() and remove the TODOs for
handling the error.
    @joyeecheung
    joyeecheung committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    908d679 View commit details
    Browse the repository at this point in the history