process: fix uid/gid validation to avoid crash #44910
Merged
+8
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id |= 0 turns unsigned 32-bit integer values exceeding the unsigned 31-bit range into negative integers, causing a crash. Use id >>>= 0 instead, which works properly for all unsigned 32-bit integers. Refs: nodejs#36786
|
Review requested:
|
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Oct 7, 2022
ErickWendel
approved these changes
Oct 7, 2022
tniessen
added
the
author ready
lpinca
approved these changes
Oct 7, 2022
aduh95
approved these changes
Oct 10, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 997334c |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
id |= 0 turns unsigned 32-bit integer values exceeding the unsigned 31-bit range into negative integers, causing a crash. Use id >>>= 0 instead, which works properly for all unsigned 32-bit integers. Refs: #36786 PR-URL: #44910 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id |= 0turns unsigned 32-bit integer values exceeding the unsigned 31-bit range into negative integers, causing a crash. Useid >>>= 0instead, which works properly for all unsigned 32-bit integers.Refs: #36786