lib: make properties on Blob and URL enumerable #44918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Oct 8, 2022
github-actions
bot
removed
the
request-ci
VoltrexKeyva
approved these changes
Oct 8, 2022
Trott
approved these changes
Oct 8, 2022
This was referenced Oct 9, 2022
jasnell
approved these changes
Oct 10, 2022
15 tasks
aduh95
approved these changes
Oct 14, 2022
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/44918 ✔ Done loading data for nodejs/node/pull/44918 ----------------------------------- PR info ------------------------------------ Title lib: make properties on Blob and URL enumerable (#44918) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch KhafraDev:make-it-enumerable -> nodejs:main Labels whatwg-url, author ready, needs-ci Commits 2 - lib: make properties on Blob and URL enumerable - fix: lint Committers 1 - Khafra <42794878+KhafraDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/44918 Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44918 Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rich Trott Reviewed-By: James M Snell Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 08 Oct 2022 03:44:16 GMT ✔ Approvals: 6 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44918#pullrequestreview-1135187207 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/44918#pullrequestreview-1135188687 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44918#pullrequestreview-1135253008 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44918#pullrequestreview-1135257021 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44918#pullrequestreview-1136265636 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/44918#pullrequestreview-1143042380 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-08T18:43:26Z: https://ci.nodejs.org/job/node-test-pull-request/47127/ - Querying data for job/node-test-pull-request/47127/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 44918 From https://github.com/nodejs/node * branch refs/pull/44918/merge -> FETCH_HEAD ✔ Fetched commits as 4264b1986150..c258b69196e7 -------------------------------------------------------------------------------- Auto-merging lib/internal/blob.js [main 473160b39a] lib: make properties on Blob and URL enumerable Author: Khafra <42794878+KhafraDev@users.noreply.github.com> Date: Fri Oct 7 23:28:28 2022 -0400 4 files changed, 49 insertions(+) [main ec08f164b1] fix: lint Author: Khafra <42794878+KhafraDev@users.noreply.github.com> Date: Sat Oct 8 00:14:32 2022 -0400 2 files changed, 5 insertions(+), 5 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/3253098127 |
nodejs-github-bot
added
the
commit-queue-failed
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6fb466b |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #44918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #44918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes properties on both URL and Blob enumerable that were not.
Refs: nodejs/undici#1690.