test_runner: add extra fields in AssertionError YAML #44952

bengl · 2022-10-10T19:30:45Z

Many TAP reporters offer special-case handling of YAML objects containing expected, actual, and operator fields, as produced by AssertionError and similar userland Error classes.

MoLow · 2022-10-14T05:36:54Z

FYI @manekinekko let's make sure this addition is compatible with #43525 after it lands

manekinekko · 2022-10-15T07:37:57Z

Yep, should be easy to add these fields here

node/lib/internal/test_runner/tap_parser.js

Lines 808 to 824 in 3b08f3c

    
           // ----------------YAMLLine---------------- 
        
           // YAMLLine := "  " (YAML)* "\n" 
        
           #YAMLLine() { 
        
             const yamlLiteral = this.#readNextLiterals(); 
        
             const { 0: key, 1: value } = StringPrototypeSplit(yamlLiteral, ':'); 
        
             switch (key) { 
        
               case 'duration_ms': 
        
                 this.#lastTestPointDuration = Number(value); 
        
                 break; 
        
               // TODO(@manekinekko): should we handle other diagnostics data? 
        
             } 
        
             ArrayPrototypePush(this.#yamlBlockBuffer, yamlLiteral); 
        
           }

manekinekko · 2022-10-16T14:00:32Z

Added in 26a2476

Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes.

nodejs-github-bot · 2022-10-25T12:38:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47465/

nodejs-github-bot · 2022-10-26T02:31:27Z

Commit Queue failed

- Loading data for nodejs/node/pull/44952
✔  Done loading data for nodejs/node/pull/44952
----------------------------------- PR info ------------------------------------
Title      test_runner: add extra fields in AssertionError YAML (#44952)
Author     Bryan English  (@bengl)
Branch     bengl:bengl/expected-actual -> nodejs:main
Labels     author ready, needs-ci, dont-land-on-v14.x, test_runner
Commits    1
 - test_runner: add extra fields in AssertionError YAML
Committers 1
 - Bryan English 
PR-URL: https://github.com/nodejs/node/pull/44952
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44952
Reviewed-By: Moshe Atlow 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test_runner: add extra fields in AssertionError YAML
   ℹ  This PR was created on Mon, 10 Oct 2022 19:30:45 GMT
   ✔  Approvals: 2
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44952#pullrequestreview-1136519381
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44952#pullrequestreview-1143346750
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-25T12:38:51Z: https://ci.nodejs.org/job/node-test-pull-request/47465/
- Querying data for job/node-test-pull-request/47465/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3325742811

nodejs-github-bot · 2022-10-26T04:00:14Z

Landed in e260b37

Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>

Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs#44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>

Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: #44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com>

Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes. PR-URL: nodejs/node#44952 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> (cherry picked from commit e260b373f13c150eb5bdf4c336d4b6b764b59c8e)

nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner labels Oct 10, 2022

bengl force-pushed the bengl/expected-actual branch from 75c6a05 to 669a977 Compare October 10, 2022 19:40

MoLow approved these changes Oct 10, 2022

View reviewed changes

jasnell approved these changes Oct 16, 2022

View reviewed changes

test_runner: add extra fields in AssertionError YAML

6f09e43

Many TAP reporters offer special-case handling of YAML objects containing `expected`, `actual`, and `operator` fields, as produced by `AssertionError` and similar userland Error classes.

bengl force-pushed the bengl/expected-actual branch from 669a977 to 6f09e43 Compare October 25, 2022 01:11

This comment was marked as outdated.

Sign in to view

bengl added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 26, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 26, 2022

MoLow approved these changes Oct 26, 2022

View reviewed changes

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 26, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2022

nodejs-github-bot merged commit e260b37 into nodejs:main Oct 26, 2022

RafaelGSS mentioned this pull request Nov 1, 2022

v19.1.0 proposal #45269

Merged

MoLow mentioned this pull request Nov 24, 2022

[v16.x backport] backport multiple test runner features #45602

Closed

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test_runner: add extra fields in AssertionError YAML #44952

test_runner: add extra fields in AssertionError YAML #44952

bengl commented Oct 10, 2022

MoLow commented Oct 14, 2022

manekinekko commented Oct 15, 2022

manekinekko commented Oct 16, 2022

This comment was marked as outdated.

nodejs-github-bot commented Oct 25, 2022

nodejs-github-bot commented Oct 26, 2022

nodejs-github-bot commented Oct 26, 2022

test_runner: add extra fields in AssertionError YAML #44952

test_runner: add extra fields in AssertionError YAML #44952

Conversation

bengl commented Oct 10, 2022

MoLow commented Oct 14, 2022

manekinekko commented Oct 15, 2022

manekinekko commented Oct 16, 2022

This comment was marked as outdated.

nodejs-github-bot commented Oct 25, 2022

nodejs-github-bot commented Oct 26, 2022

nodejs-github-bot commented Oct 26, 2022