test: improve test coverage for os package
#44959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
cjihrig
reviewed
Oct 12, 2022
Comment on lines
113
to
114
| // From libuv docs | ||
| // "The priority value range is between -20 (high priority) and 19 (low priority)" |
There was a problem hiding this comment.
This comment isn't really relevant here (or there is a bug in the code change). The range mentioned here is the priority that is passed to setPriority(), but you're calling getPriority().
The code change here is trying to get the priority of process id = -21. That explains why the error is ESRCH - although not on macOS apparently.
There was a problem hiding this comment.
That makes sense. I will remove the comment.
Replacing -21 w/ -1 (negative numbers in general) should make the same effect; for that case, macOS will always return EINVAL as described in the getpriority() macOS ref. I will change the expected error to do a "match" instead.
juanarbol
force-pushed
the
juan/os-getpriority-test
branch
from
6c3c9e9
to
fac591b
Compare
lpinca
approved these changes
Oct 14, 2022
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Oct 15, 2022
jasnell
approved these changes
Oct 15, 2022
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5e30559 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #44959 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #44959 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44959 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #44959 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #44959 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.