New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] watch mode #44976

Closed

MoLow wants to merge 4 commits into nodejs:v16.x-staging from MoLow:backport-v16-watch-mode

Member

MoLow commented Oct 12, 2022 •

edited

backport of
#44366
#44551
#44621
#44739

This comment was marked as off-topic.

Sign in to view

nodejs-github-bot added lib / src needs-ci v16.x labels

MoLow added the commit-queue-rebase label

MoLow added a commit to MoLow/node that referenced this pull request


          cli: add --watch

cdb114e

PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44976
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request


          test: split watch mode inspector tests to sequential

69c7a41

PR-URL: nodejs#44551
Backport-PR-URL: nodejs#44976
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request


          test: deflake watch mode tests

09593b9

PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request


          test: fix watch mode test flake

cd3a54f

PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow force-pushed the backport-v16-watch-mode branch from e3581a5 to cd3a54f Compare

October 12, 2022 09:29

MoLow marked this pull request as ready for review

October 12, 2022 09:31

MoLow added a commit to MoLow/node that referenced this pull request


          cli: add --watch

7c5ae65

PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44976
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request


          test: split watch mode inspector tests to sequential

191eaec

PR-URL: nodejs#44551
Backport-PR-URL: nodejs#44976
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request


          test: deflake watch mode tests

7de120a

PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow added a commit to MoLow/node that referenced this pull request


          test: fix watch mode test flake

72bf89e

PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow force-pushed the backport-v16-watch-mode branch from cd3a54f to 72bf89e Compare

October 12, 2022 16:22

MoLow added 4 commits

October 12, 2022 22:44


          cli: add --watch

4c6ac5d

PR-URL: nodejs#44366
Backport-PR-URL: nodejs#44976
Fixes: nodejs#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>


          test: split watch mode inspector tests to sequential

880c48d

PR-URL: nodejs#44551
Backport-PR-URL: nodejs#44976
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>


          test: deflake watch mode tests

fc94a10

PR-URL: nodejs#44621
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>


          test: fix watch mode test flake

d8f559e

PR-URL: nodejs#44739
Backport-PR-URL: nodejs#44976
Fixes: nodejs#44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow force-pushed the backport-v16-watch-mode branch from 72bf89e to d8f559e Compare

October 12, 2022 19:44

MoLow added the request-ci label

github-actions bot removed the request-ci label

This comment was marked as off-topic.

Sign in to view

Collaborator

nodejs-github-bot commented Oct 13, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47250/

mfranzke mentioned this pull request

replace nodemon db-ui/base#89

Open

danielleadams approved these changes

View reviewed changes

JungMinu approved these changes

View reviewed changes

MoLow added the watch-mode label

Member Author

MoLow commented Oct 29, 2022

@nodejs/releasers Hey, can this be merged in advance, a few days before the next node 16 release? #44873 depends on it

MoLow mentioned this pull request

[v16.x backport] test runner additions #44873

Closed

richardlau pushed a commit that referenced this pull request


          cli: add --watch

1e0dcd1

PR-URL: #44366
Backport-PR-URL: #44976
Fixes: #40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

richardlau pushed a commit that referenced this pull request


          test: split watch mode inspector tests to sequential

97f6caf

PR-URL: #44551
Backport-PR-URL: #44976
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

richardlau pushed a commit that referenced this pull request


          test: deflake watch mode tests

543d3d2

PR-URL: #44621
Backport-PR-URL: #44976
Fixes: #44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

richardlau pushed a commit that referenced this pull request


          test: fix watch mode test flake

6d736a5

PR-URL: #44739
Backport-PR-URL: #44976
Fixes: #44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Member

richardlau commented Nov 23, 2022

Landed in 6f541d9...6d736a5

richardlau closed this

MoLow deleted the backport-v16-watch-mode branch

November 23, 2022 22:06

MoLow added the backported-to-v16.x label

guangwong pushed a commit to noslate-project/node that referenced this pull request


          cli: add --watch

5cbcf30

PR-URL: nodejs/node#44366
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request


          test: split watch mode inspector tests to sequential

f9e84ab

PR-URL: nodejs/node#44551
Backport-PR-URL: nodejs/node#44976
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request


          test: deflake watch mode tests

PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request


          test: fix watch mode test flake

f2117be

PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request


          cli: add --watch

8631c77

PR-URL: nodejs/node#44366
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request


          test: split watch mode inspector tests to sequential

e4d5211

PR-URL: nodejs/node#44551
Backport-PR-URL: nodejs/node#44976
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request


          test: deflake watch mode tests

f8bdc2e

PR-URL: nodejs/node#44621
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

guangwong pushed a commit to noslate-project/node that referenced this pull request


          test: fix watch mode test flake

fb703a7

PR-URL: nodejs/node#44739
Backport-PR-URL: nodejs/node#44976
Fixes: nodejs/node#44735
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

richardlau mentioned this pull request

Metadata Proposal for Docs nodejs/next-10#166

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment