Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: improve port validation #45012

Merged
merged 3 commits into from Oct 17, 2022
Merged

url: improve port validation #45012

merged 3 commits into from Oct 17, 2022

Commits on Oct 15, 2022

  1. url: improve port validation 

    If a port is not a number, throw rather than treating the `:` that
delineates the port as part of the path. This is consistent with WHATWG
URL and also mitigates hostname-spoofing.

Concerns about hostname-spoofing were raised and presented in excellent
detail by pyozzi-toss (pyozzi@toss.im/Security-Tech Team in Toss).
    @Trott
    Trott committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    c48ebb7 View commit details
    Browse the repository at this point in the history

  2. fixup! url: improve port validation

    @Trott
    Trott committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    991d54c View commit details
    Browse the repository at this point in the history

  3. fixup! fixup! url: improve port validation

    @Trott
    Trott committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    82bef86 View commit details
    Browse the repository at this point in the history