Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: don't push null from closed promise #42694 #45026

Merged
merged 1 commit into from Oct 22, 2022
Merged

stream: don't push null from closed promise #42694 #45026

merged 1 commit into from Oct 22, 2022

Commits on Oct 17, 2022

  1. stream: don't push null from closed promise #42694 

    closed promise is subscribed to first so will be
resolved first, before any read promise.

This causes data after EOF error to be thrown.

Remove the push null from the closed promise handler.
The push null gets done from the read handler
when it detects done.
    @davedoesdev
    davedoesdev committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    c45d16b View commit details
    Browse the repository at this point in the history