lib: add ability to add separate event name to defineEventHandler #45032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an optional third argument to `defineEventHandler()` to specify an event name that is separate from the name used for the property. This will be used, for instance, by the quic implementation to support generating the `on...` events where the event name itself is hyphenated. For instance `defineEventHandler(target, 'streamreset', 'stream-reset')` Separated out from nodejs#44325 Signed-off-by: James M Snell <jasnell@gmail.com>
Draft
aduh95
approved these changes
Oct 16, 2022
anonrig
approved these changes
Oct 17, 2022
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Oct 18, 2022
jasnell
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1f7e8d6 |
This was referenced Oct 20, 2022
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
Adds an optional third argument to `defineEventHandler()` to specify an event name that is separate from the name used for the property. This will be used, for instance, by the quic implementation to support generating the `on...` events where the event name itself is hyphenated. For instance `defineEventHandler(target, 'streamreset', 'stream-reset')` Separated out from #44325 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45032 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Adds an optional third argument to `defineEventHandler()` to specify an event name that is separate from the name used for the property. This will be used, for instance, by the quic implementation to support generating the `on...` events where the event name itself is hyphenated. For instance `defineEventHandler(target, 'streamreset', 'stream-reset')` Separated out from #44325 Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45032 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
@jasnell this didn't land cleanly on v18.x. Do you mind backporting this? Thank you. |
danielleadams
added
the
backport-requested-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional third argument to
defineEventHandler()to specify an event name that is separate from the name used for the property. This will be used, for instance, by the quic implementation to support generating theon...events where the event name itself is hyphenated. For instancedefineEventHandler(target, 'streamreset', 'stream-reset')Separated out from #44325
This is an internal only api so no documentation change is needed.
Signed-off-by: James M Snell jasnell@gmail.com