http: Add priority to common http headers #45045

jasnell · 2022-10-17T22:05:13Z

The standard Priority header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell jasnell@gmail.com

Extracted from the quic PR here: #44325

/cc @nodejs/http @nodejs/http2

nodejs-github-bot · 2022-10-17T22:05:17Z

Review requested:

@nodejs/http
@nodejs/http2
@nodejs/net

src/node_http_common.h

anonrig

lgtm

mcollina

lgtm

nodejs-github-bot · 2022-10-18T14:39:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47323/ 💛

jasnell · 2022-10-18T20:01:18Z

the github action asan test is failing for entirely unrelated reasons due to a flaky watch test

The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com>

github-actions · 2022-10-19T02:36:46Z

Fast-track has been requested by @jasnell. Please 👍 to approve.

nodejs-github-bot · 2022-10-19T14:05:29Z

Commit Queue failed

- Loading data for nodejs/node/pull/45045
✔  Done loading data for nodejs/node/pull/45045
----------------------------------- PR info ------------------------------------
Title      http: Add priority to common http headers (#45045)
Author     James M Snell  (@jasnell)
Branch     jasnell:add-http-priority-header -> nodejs:main
Labels     c++, fast-track, author ready
Commits    1
 - http: add priority to common http headers
Committers 1
 - James M Snell 
PR-URL: https://github.com/nodejs/node/pull/45045
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Robert Nagy 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45045
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Robert Nagy 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - http: add priority to common http headers
   ℹ  This PR was created on Mon, 17 Oct 2022 22:05:13 GMT
   ✔  Approvals: 6
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1144864402
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145011496
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145108209
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145112248
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145659186
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145900509
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-18T14:39:41Z: https://ci.nodejs.org/job/node-test-pull-request/47323/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - http: add priority to common http headers
- Querying data for job/node-test-pull-request/47323/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3282243031

jasnell · 2022-10-19T14:34:49Z

Landed in 112bf50

The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #45045 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 17, 2022

jasnell mentioned this pull request Oct 17, 2022

src: quic #44325

Draft

aduh95 approved these changes Oct 17, 2022

View reviewed changes

jasnell force-pushed the add-http-priority-header branch from 424c4fe to c801c45 Compare October 17, 2022 22:11

This comment was marked as outdated.

Sign in to view

jasnell commented Oct 17, 2022

View reviewed changes

src/node_http_common.h Show resolved Hide resolved

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2022

jasnell force-pushed the add-http-priority-header branch from c801c45 to 8b6d4ee Compare October 17, 2022 22:46

This comment was marked as outdated.

Sign in to view

anonrig approved these changes Oct 18, 2022

View reviewed changes

mcollina approved these changes Oct 18, 2022

View reviewed changes

ronag approved these changes Oct 18, 2022

View reviewed changes

RafaelGSS approved these changes Oct 18, 2022

View reviewed changes

RaisinTen approved these changes Oct 18, 2022

View reviewed changes

jasnell removed the needs-ci PRs that need a full CI run. label Oct 18, 2022

github-actions bot mentioned this pull request Oct 19, 2022

CI Reliability 2022-10-19 nodejs/reliability#404

Open

15 tasks

http: add priority to common http headers

7f311d9

The standard `Priority` header is defined in RFC 9218. This is added as part of the precusor to quic/http3 work. Signed-off-by: James M Snell <jasnell@gmail.com>

jasnell force-pushed the add-http-priority-header branch from 8b6d4ee to 7f311d9 Compare October 19, 2022 02:29

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 19, 2022

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 19, 2022

jasnell closed this Oct 19, 2022

This was referenced Oct 20, 2022

CI Reliability 2022-10-20 nodejs/reliability#405

Open

CI Reliability 2022-10-21 nodejs/reliability#406

Open

CI Reliability 2022-10-22 nodejs/reliability#407

Open

RafaelGSS mentioned this pull request Nov 1, 2022

v19.1.0 proposal #45269

Merged

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: Add priority to common http headers #45045

http: Add priority to common http headers #45045

jasnell commented Oct 17, 2022

nodejs-github-bot commented Oct 17, 2022

This comment was marked as outdated.

This comment was marked as outdated.

anonrig left a comment

mcollina left a comment

nodejs-github-bot commented Oct 18, 2022 •

edited by jasnell

jasnell commented Oct 18, 2022

github-actions bot commented Oct 19, 2022

nodejs-github-bot commented Oct 19, 2022

jasnell commented Oct 19, 2022

http: Add priority to common http headers #45045

http: Add priority to common http headers #45045

Conversation

jasnell commented Oct 17, 2022

nodejs-github-bot commented Oct 17, 2022

This comment was marked as outdated.

This comment was marked as outdated.

anonrig left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Oct 18, 2022 • edited by jasnell

jasnell commented Oct 18, 2022

github-actions bot commented Oct 19, 2022

nodejs-github-bot commented Oct 19, 2022

jasnell commented Oct 19, 2022

nodejs-github-bot commented Oct 18, 2022 •

edited by jasnell