Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix v14.x link maintaining openssl guide #45071

Closed

Conversation

RafaelGSS
Copy link
Member

The document indicates the file lives under /blob/v14.x-staging/doc/contributing/maintaining-openssl.md which is false on v14.x branch.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 19, 2022
@RafaelGSS RafaelGSS force-pushed the doc/maintaining-openssl-v14-fix branch from 1337e2b to c04409f Compare October 19, 2022 12:40
@RafaelGSS RafaelGSS force-pushed the doc/maintaining-openssl-v14-fix branch from c04409f to b571a73 Compare October 19, 2022 13:36
@aduh95
Copy link
Contributor

aduh95 commented Oct 19, 2022

Why adding a link for v14.x and not v16.x?

@RafaelGSS
Copy link
Member Author

Why adding a link for v14.x and not v16.x?

The v16.x version of that document exists. The issue is that the v14.x of that document lives in a different namespace (guides/*)

@aduh95
Copy link
Contributor

aduh95 commented Oct 19, 2022

Oh you mean on the GitHub UI, yeah OK makes sense.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS force-pushed the doc/maintaining-openssl-v14-fix branch from b571a73 to 8231341 Compare October 22, 2022 04:11
@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45071
✔  Done loading data for nodejs/node/pull/45071
----------------------------------- PR info ------------------------------------
Title      doc: fix v14.x link maintaining openssl guide (#45071)
Author     Rafael Gonzaga  (@RafaelGSS)
Branch     RafaelGSS:doc/maintaining-openssl-v14-fix -> nodejs:main
Labels     doc, author ready
Commits    1
 - doc: fix v14.x link maintaining openssl guide
Committers 1
 - RafaelGSS 
PR-URL: https://github.com/nodejs/node/pull/45071
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45071
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - doc: fix v14.x link maintaining openssl guide
   ℹ  This PR was created on Wed, 19 Oct 2022 12:31:55 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45071#pullrequestreview-1147646586
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45071#pullrequestreview-1148034313
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3303153329

RafaelGSS added a commit that referenced this pull request Oct 22, 2022
PR-URL: #45071
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS
Copy link
Member Author

Landed in 3a4f964

@RafaelGSS RafaelGSS closed this Oct 22, 2022
RafaelGSS added a commit that referenced this pull request Nov 1, 2022
PR-URL: #45071
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS added a commit that referenced this pull request Nov 10, 2022
PR-URL: #45071
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45071
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45071
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45071
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants