Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x] build: remove redundant condition from common.gypi #45076

Merged
merged 1 commit into from Nov 23, 2022

Commits on Nov 23, 2022

  1. build: remove redundant condition from common.gypi

    Both paths for the condition being removed result in the same
    value being assigned to `openssl_product`. This condition was
    also problematic as it was testing a variable in the same scope
    which gyp/gyp-next currently does not support.
    
    Refs: https://gyp.gsrc.io/docs/InputFormatReference.md#user_defined-variables
    PR-URL: nodejs#45076
    Refs: nodejs/node-gyp#2750
    Refs: nodejs#38633
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    richardlau committed Nov 23, 2022
    Copy the full SHA
    ac24c80 View commit details
    Browse the repository at this point in the history