Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused contextify_global_private_symbol #45128

Merged
merged 1 commit into from Oct 24, 2022
Merged

src: remove unused contextify_global_private_symbol #45128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/env_properties.h
View file
Open in desktop
Expand Up @@ -20,7 +20,6 @@
#define PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V) \
V(arrow_message_private_symbol, "node:arrowMessage") \
V(contextify_context_private_symbol, "node:contextify:context") \
V(contextify_global_private_symbol, "node:contextify:global") \
V(decorated_private_symbol, "node:decorated") \
V(napi_type_tag, "node:napi:type_tag") \
V(napi_wrapper, "node:napi:wrapper") \
Expand Down
13 changes: 6 additions & 7 deletions typings/internalBinding/util.d.ts
View file
Open in desktop
Expand Up @@ -8,15 +8,14 @@ declare namespace InternalUtilBinding {
}

declare function InternalBinding(binding: 'util'): {
// PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env.h
// PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env_properties.h
arrow_message_private_symbol: 1;
contextify_context_private_symbol: 2;
contextify_global_private_symbol: 3;
decorated_private_symbol: 4;
napi_type_tag: 5;
napi_wrapper: 6;
untransferable_object_private_symbol: 7;
exiting_aliased_Uint32Array: 8;
decorated_private_symbol: 3;
napi_type_tag: 4;
napi_wrapper: 5;
untransferable_object_private_symbol: 6;
exiting_aliased_Uint32Array: 7;

kPending: 0;
kFulfilled: 1;
Expand Down