stream: fix duplexify premature destroy #45133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: nodejs#44925
|
Review requested:
|
ronag
added
stream
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Oct 23, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
xtx1130
reviewed
Oct 24, 2022
jasnell
reviewed
Oct 24, 2022
juanarbol
approved these changes
Oct 24, 2022
16 tasks
github-actions
bot
removed
the
request-ci
This was referenced Oct 26, 2022
ronag
added
the
commit-queue
|
@mcollina what is our procedure to include these kind of PR's in readable-stream? |
|
Once it ship in a version of Node (ideally the 18 series) I can open a PR update. |
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45133 ✔ Done loading data for nodejs/node/pull/45133 ----------------------------------- PR info ------------------------------------ Title stream: fix duplexify premature destroy (#45133) Author Robert Nagy (@ronag) Branch ronag:fix-44925 -> nodejs:main Labels stream, author ready Commits 2 - stream: fix duplexify premature destroy - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/45133 Fixes: https://github.com/nodejs/node/issues/44925 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Juan José Arboleda ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45133 Fixes: https://github.com/nodejs/node/issues/44925 Reviewed-By: Matteo Collina Reviewed-By: Benjamin Gruenbaum Reviewed-By: Juan José Arboleda -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ℹ This PR was created on Sun, 23 Oct 2022 13:51:44 GMT ✔ Approvals: 3 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45133#pullrequestreview-1152327819 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/45133#pullrequestreview-1152332503 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/45133#pullrequestreview-1153558445 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-25T14:51:07Z: https://ci.nodejs.org/job/node-test-pull-request/47472/ - Querying data for job/node-test-pull-request/47472/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3336681891 |
juanarbol
pushed a commit
that referenced
this pull request
Oct 27, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
|
Landed in b6eba6b |
10 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error. Fixes: #44925 PR-URL: #45133 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos
added
backported-to-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplexified Duplex should be autoDestroyed instead of prematurely destroyed when the readable and writable sides have finished without error.
Fixes: #44925