dns: fix port validation #45135
Merged
dns: fix port validation #45135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the error message generation would throw if the port was of type `"symbol"`.
nodejs-github-bot
added
errors
BridgeAR
approved these changes
Oct 23, 2022
aduh95
added
author ready
Trott
approved these changes
Oct 23, 2022
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Oct 23, 2022
VoltrexKeyva
approved these changes
Oct 23, 2022
This comment was marked as outdated.
This comment was marked as outdated.
13 tasks
jasnell
approved these changes
Oct 24, 2022
anonrig
approved these changes
Oct 24, 2022
juanarbol
approved these changes
Oct 24, 2022
juanarbol
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/45135 ✔ Done loading data for nodejs/node/pull/45135 ----------------------------------- PR info ------------------------------------ Title dns: fix port validation (#45135) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-port-validation -> nodejs:main Labels errors, author ready, needs-ci Commits 1 - dns: fix port validation Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/45135 Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: James M Snell Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45135 Reviewed-By: Ruben Bridgewater Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: James M Snell Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 23 Oct 2022 16:39:55 GMT ✔ Approvals: 7 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152334332 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152334691 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152346904 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152368653 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152591810 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45135#pullrequestreview-1152962208 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/45135#pullrequestreview-1153554466 ✖ This PR needs to wait 22 more hours to land ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-24T15:11:51Z: https://ci.nodejs.org/job/node-test-pull-request/47443/ - Querying data for job/node-test-pull-request/47443/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3315003203 |
nodejs-github-bot
added
the
commit-queue-failed
16 tasks
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 53cd3d8 |
This was referenced Oct 26, 2022
10 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
Previously the error message generation would throw if the port was of type `"symbol"`. PR-URL: #45135 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
Previously the error message generation would throw if the port was of type `"symbol"`. PR-URL: #45135 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
4 tasks
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Previously the error message generation would throw if the port was of type `"symbol"`. PR-URL: #45135 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
Previously the error message generation would throw if the port was of type `"symbol"`. PR-URL: #45135 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Previously the error message generation would throw if the port was of type `"symbol"`. PR-URL: #45135 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the error message generation would throw if the port was of type
"symbol".