Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: align @@toStringTag with other Web Streams implementations #45136

Closed
wants to merge 1 commit into from
Closed

stream: align @@toStringTag with other Web Streams implementations #45136

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 23, 2022 •
edited

None of the other implementations are using a getter, let's align.

Alternative to #45117.
Fixes: #45114

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Oct 23, 2022
@aduh95 aduh95 mentioned this pull request Oct 23, 2022
Merged
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47427/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2022
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 26, 2022

Supplanted by #45117

@aduh95 aduh95 closed this Oct 26, 2022
@aduh95 aduh95 deleted the webstream-toStringTag branch October 26, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@daeyeon daeyeon daeyeon approved these changes

@F3n67u F3n67u F3n67u approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web streams have no Symbol.toStringTag on their prototypes
8 participants
@aduh95 @nodejs-github-bot @jasnell @benjamingr @lpinca @targos @daeyeon @F3n67u