Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: remove unused language files #45138

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled.

There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential contributor.

Refs: #45090

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Oct 23, 2022
@bnoordhuis
Copy link
Member Author

"installer" has definitely been used in the past, silly bot.

@Trott
Copy link
Member

Trott commented Oct 24, 2022

"installer" has definitely been used in the past, silly bot.

If you want to add installer, we'll need to add it to https://github.com/nodejs/core-validate-commit/blob/a3cb753bc1a2d57457959ffd28578c2b44aa93a4/lib/rules/subsystem.js.

The installer subsystem hasn't been used in a commit message for over six years, though. It's probably easier to switch the commit message here to build (or tools).

i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: nodejs#45090
@bnoordhuis
Copy link
Member Author

I took the path of least resistance and switched to build:

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

anonrig pushed a commit that referenced this pull request Oct 27, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@anonrig
Copy link
Member

anonrig commented Oct 27, 2022

Landed in 9c13e05

@anonrig anonrig closed this Oct 27, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants