Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use the v1 branch instead of a commit hash #45164

Closed
wants to merge 1 commit into from
Closed

tools: use the v1 branch instead of a commit hash #45164

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 25, 2022

Use the v1 branch for the gr2m/create-or-update-pull-request-action. Explicit tags and commit hashes do not include the dist folder.

Refs: #45022 (comment)

@lpinca
tools: use the v1 branch instead of a commit hash
0959986 
Use the v1 branch for the gr2m/create-or-update-pull-request-action.
Explicit tags and commit hashes do not include the `dist` folder.

Refs: nodejs#45022 (comment)
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 25, 2022
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 25, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

aduh95
aduh95 requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The security concerns are still there, I don't think reverting to tags is the right move here. IMO reverting ef17711 would be a better quick fix, or finding the right hash to use would be even better.

@lpinca lpinca closed this Oct 25, 2022
@lpinca lpinca deleted the use/v1-branch branch October 25, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 requested changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lpinca @nodejs-github-bot @targos @aduh95