doc: add more LTS update steps to the release guide #45177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
Hopefully this now captures all the still-undocumented steps required for the LTS promotion 🙏 |
RafaelGSS
approved these changes
Oct 25, 2022
ruyadorno
force-pushed
the
add-more-lts-update-steps-to-release-guide
branch
from
ffddac6
to
d45c09c
Compare
richardlau
approved these changes
Oct 25, 2022
This changeset adds references to two steps required for promoting a release line to LTS: - Adding the new codename to nodejs-latest-linker repo - Adding codename info to the Release repo Signed-off-by: Ruy Adorno <ruyadorno@google.com>
ruyadorno
force-pushed
the
add-more-lts-update-steps-to-release-guide
branch
from
d45c09c
to
5d5fcf7
Compare
anonrig
approved these changes
Oct 27, 2022
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45177 ✔ Done loading data for nodejs/node/pull/45177 ----------------------------------- PR info ------------------------------------ Title doc: add more LTS update steps to the release guide (#45177) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ruyadorno:add-more-lts-update-steps-to-release-guide -> nodejs:main Labels doc Commits 1 - doc: add more lts update steps to release guide Committers 1 - Ruy Adorno PR-URL: https://github.com/nodejs/node/pull/45177 Reviewed-By: Rafael Gonzaga Reviewed-By: Richard Lau Reviewed-By: Michael Dawson Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45177 Reviewed-By: Rafael Gonzaga Reviewed-By: Richard Lau Reviewed-By: Michael Dawson Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 25 Oct 2022 17:02:45 GMT ✔ Approvals: 4 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45177#pullrequestreview-1155183837 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45177#pullrequestreview-1155196395 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/45177#pullrequestreview-1157200015 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45177#pullrequestreview-1158219837 ✖ This PR needs to wait 3 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3337834149 |
ruyadorno
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e17e903 |
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2022
This changeset adds references to two steps required for promoting a release line to LTS: - Adding the new codename to nodejs-latest-linker repo - Adding codename info to the Release repo Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45177 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 10, 2022
This changeset adds references to two steps required for promoting a release line to LTS: - Adding the new codename to nodejs-latest-linker repo - Adding codename info to the Release repo Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45177 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
This changeset adds references to two steps required for promoting a release line to LTS: - Adding the new codename to nodejs-latest-linker repo - Adding codename info to the Release repo Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45177 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
This changeset adds references to two steps required for promoting a release line to LTS: - Adding the new codename to nodejs-latest-linker repo - Adding codename info to the Release repo Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45177 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
This changeset adds references to two steps required for promoting a release line to LTS: - Adding the new codename to nodejs-latest-linker repo - Adding codename info to the Release repo Signed-off-by: Ruy Adorno <ruyadorno@google.com> PR-URL: #45177 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds references to two steps required for promoting a release line to LTS:
cc @nodejs/releasers