Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: change make lint to make lint-md #45197

Closed
wants to merge 1 commit into from
Closed

doc: change make lint to make lint-md #45197

wants to merge 1 commit into from

Conversation

RafaelGSS
Copy link
Member

This change might save some time during the release steps.

cc: @nodejs/releasers

@RafaelGSS
doc: change make lint to make lint-md
202417d 
This change might save some time during the release steps
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 27, 2022
juanarbol
juanarbol reviewed Oct 27, 2022
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why skip js linter but no cc linter?

@targos
Copy link
Member

targos commented Oct 27, 2022

@juanarbol The release commit contains changes to the documentation (md) and src/node_version.h (cc)

mhdawson
mhdawson approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanarbol
juanarbol approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RafaelGSS added a commit that referenced this pull request Oct 27, 2022
@RafaelGSS
doc: change make lint to make lint-md
67edd72 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@RafaelGSS
Copy link
Member Author

Landed in 67edd72

@RafaelGSS RafaelGSS closed this Oct 27, 2022
RafaelGSS added a commit that referenced this pull request Nov 1, 2022
@RafaelGSS
doc: change make lint to make lint-md
9f546f0 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS added a commit that referenced this pull request Nov 10, 2022
@RafaelGSS
doc: change make lint to make lint-md
c179c14 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@RafaelGSS @danielleadams
doc: change make lint to make lint-md
444ac57 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@RafaelGSS @danielleadams
doc: change make lint to make lint-md
4f768d2 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@RafaelGSS @danielleadams
doc: change make lint to make lint-md
4e87c36 
This change might save some time during the release steps

PR-URL: #45197
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@RafaelGSS @nodejs-github-bot @targos @ruyadorno @Trott @mhdawson @aduh95 @juanarbol