Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 10.7.193.20 #45228

Merged
merged 1 commit into from Nov 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions deps/v8/DEPS
Expand Up @@ -37,7 +37,6 @@ vars = {
'download_jsfunfuzz': False,
'download_prebuilt_bazel': False,
'check_v8_header_includes': False,
'checkout_reclient': False,

# By default, download the fuchsia sdk from the public sdk directory.
'fuchsia_sdk_cipd_prefix': 'fuchsia/sdk/gn/',
Expand Down Expand Up @@ -143,7 +142,7 @@ deps = {
}
],
'dep_type': 'cipd',
'condition': '(host_os == "linux" or host_os == "mac" or host_os == "win") and checkout_reclient',
'condition': '(host_os == "linux" or host_os == "mac" or host_os == "win") and host_cpu != "s390" and host_cpu != "ppc"',
},
'test/benchmarks/data':
Var('chromium_url') + '/v8/deps/third_party/benchmarks.git' + '@' + '05d7188267b4560491ff9155c5ee13e207ecd65f',
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 10
#define V8_MINOR_VERSION 7
#define V8_BUILD_NUMBER 193
#define V8_PATCH_LEVEL 16
#define V8_PATCH_LEVEL 20

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
12 changes: 9 additions & 3 deletions deps/v8/src/compiler/access-info.cc
Expand Up @@ -451,9 +451,15 @@ PropertyAccessInfo AccessInfoFactory::ComputeDataFieldAccessInfo(
map, descriptor, details_representation));
} else if (details_representation.IsHeapObject()) {
if (descriptors_field_type->IsNone()) {
// Store is not safe if the field type was cleared.
if (access_mode == AccessMode::kStore) {
return Invalid();
switch (access_mode) {
case AccessMode::kStore:
case AccessMode::kStoreInLiteral:
case AccessMode::kDefine:
// Store is not safe if the field type was cleared.
return Invalid();
case AccessMode::kLoad:
case AccessMode::kHas:
break;
}

// The field type was cleared by the GC, so we don't know anything
Expand Down
8 changes: 8 additions & 0 deletions deps/v8/src/wasm/graph-builder-interface.cc
Expand Up @@ -88,6 +88,7 @@ class WasmGraphBuildingInterface {
struct TryInfo : public ZoneObject {
SsaEnv* catch_env;
TFNode* exception = nullptr;
bool first_catch = true;

bool might_throw() const { return exception != nullptr; }

Expand Down Expand Up @@ -936,6 +937,10 @@ class WasmGraphBuildingInterface {

TFNode* exception = block->try_info->exception;
SetEnv(block->try_info->catch_env);
if (block->try_info->first_catch) {
LoadContextIntoSsa(ssa_env_, decoder);
block->try_info->first_catch = false;
}

TFNode* if_catch = nullptr;
TFNode* if_no_catch = nullptr;
Expand Down Expand Up @@ -1013,6 +1018,9 @@ class WasmGraphBuildingInterface {
}

SetEnv(block->try_info->catch_env);
if (block->try_info->first_catch) {
LoadContextIntoSsa(ssa_env_, decoder);
}
}

void AtomicOp(FullDecoder* decoder, WasmOpcode opcode,
Expand Down